Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: allow passing gax instance to client constructor #584

Merged
merged 5 commits into from
Sep 1, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Aug 26, 2022

  • Regenerate this pull request now.

PiperOrigin-RevId: 470911839

Source-Link: googleapis/googleapis@3527566

Source-Link: https://github.com/googleapis/googleapis-gen/commit/f16a1d224f00a630ea43d6a9a1a31f566f45cdea
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9

feat: accept google-gax instance as a parameter
Please see the documentation of the client constructor for details.

PiperOrigin-RevId: 470332808

Source-Link: googleapis/googleapis@d4a2367

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e97a1ac204ead4fe7341f91e72db7c6ac6016341
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9

Please see the documentation of the client constructor for details.

PiperOrigin-RevId: 470332808

Source-Link: googleapis/googleapis@d4a2367

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e97a1ac204ead4fe7341f91e72db7c6ac6016341
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners August 26, 2022 23:49
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 26, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: cloudiot Issues related to the googleapis/nodejs-iot API. labels Aug 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2022
@snippet-bot
Copy link

snippet-bot bot commented Aug 26, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Aug 26, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2022
PiperOrigin-RevId: 470911839

Source-Link: googleapis/googleapis@3527566

Source-Link: https://github.com/googleapis/googleapis-gen/commit/f16a1d224f00a630ea43d6a9a1a31f566f45cdea
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: accept google-gax instance as a parameter fix: use _gaxModule when accessing gax for bundling Aug 30, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Aug 30, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Aug 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2022
@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Sep 1, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2022
@alexander-fenster alexander-fenster changed the title fix: use _gaxModule when accessing gax for bundling fix: allow passing gax instance to client constructor Sep 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4bbcd42 into main Sep 1, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch September 1, 2022 20:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 1, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 22, 2022
🤖 I have created a release *beep* *boop*
---


## [3.1.1](v3.1.0...v3.1.1) (2022-09-22)


### Bug Fixes

* Allow passing gax instance to client constructor ([#584](#584)) ([4bbcd42](4bbcd42))
* Better support for fallback mode ([#580](#580)) ([8a387d0](8a387d0))
* Change import long to require ([#581](#581)) ([2ad4aac](2ad4aac))
* **deps:** Update dependency @google-cloud/iot to v3 ([#576](#576)) ([12bf4a7](12bf4a7))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-iot/issues/1553)) ([#583](#583)) ([24729a5](24729a5))
* Preserve default values in x-goog-request-params header ([#586](#586)) ([cced8e7](cced8e7))
* Remove pip install statements ([#1546](https://github.com/googleapis/nodejs-iot/issues/1546)) ([#582](#582)) ([c6bb3f9](c6bb3f9))
* use google-gax v3.3.0 ([24729a5](24729a5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [3.1.1](googleapis/nodejs-iot@v3.1.0...v3.1.1) (2022-09-22)


### Bug Fixes

* Allow passing gax instance to client constructor ([#584](googleapis/nodejs-iot#584)) ([4bbcd42](googleapis/nodejs-iot@4bbcd42))
* Better support for fallback mode ([#580](googleapis/nodejs-iot#580)) ([8a387d0](googleapis/nodejs-iot@8a387d0))
* Change import long to require ([#581](googleapis/nodejs-iot#581)) ([2ad4aac](googleapis/nodejs-iot@2ad4aac))
* **deps:** Update dependency @google-cloud/iot to v3 ([#576](googleapis/nodejs-iot#576)) ([12bf4a7](googleapis/nodejs-iot@12bf4a7))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-iot/issues/1553)) ([#583](googleapis/nodejs-iot#583)) ([24729a5](googleapis/nodejs-iot@24729a5))
* Preserve default values in x-goog-request-params header ([#586](googleapis/nodejs-iot#586)) ([cced8e7](googleapis/nodejs-iot@cced8e7))
* Remove pip install statements ([#1546](https://github.com/googleapis/nodejs-iot/issues/1546)) ([#582](googleapis/nodejs-iot#582)) ([c6bb3f9](googleapis/nodejs-iot@c6bb3f9))
* use google-gax v3.3.0 ([24729a5](googleapis/nodejs-iot@24729a5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudiot Issues related to the googleapis/nodejs-iot API. owl-bot-copy size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants