Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Node.js's built-in 'querystring' module #564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jviide
Copy link

@jviide jviide commented Jul 21, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #563 🦕

This pull request suggests using Node.js's built-in querystring module for serializing query strings. It's used in a way that uses %20 to encode spaces instead of Gaxios's default +.

A test for http2.ts's custom parameter serialization functionality is added. As a result the overall test coverage goes up a bit.

@jviide jviide requested a review from a team as a code owner July 21, 2024 16:33
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 21, 2024
@jviide jviide changed the title chore: use Node.js's builtin 'querystring' module chore: use Node.js's built-in 'querystring' module Jul 21, 2024
@jviide jviide force-pushed the qs-to-querystring branch from 7a4e465 to a6f7758 Compare July 21, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Use Node.js's built-in 'querystring' module instead of 'qs'
2 participants