feat: add universe support to googleapis libraries #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,7 +160,11 @@ async function createAPIRequestAsync<T>(parameters: APIRequestParams) { | |||
|
|
|||
| // Parse urls | |||
| if (options.url) { | |||
| options.url = urlTemplate.parse(options.url).expand(params); | |||
| let url = options.url; | |||
There was a problem hiding this comment.
This is an unrelated fix: without this, the existing code does not compile on the new TypeScript version.
| @@ -69,7 +69,7 @@ | |||
| "karma-mocha": "^2.0.0", | |||
| "karma-remap-coverage": "^0.1.5", | |||
| "karma-sourcemap-loader": "^0.4.0", | |||
| "karma-webpack": "^5.0.0", | |||
| "karma-webpack": "^4.0.0", | |||
There was a problem hiding this comment.
This is unrelated, webpack and karma-webpack v5 require Node 18 and it breaks tests. These are dev dependencies, we don't really care.
alexander-fenster
changed the title
sofisl
approved these changes
Mar 21, 2024
viacheslav-rostovtsev
approved these changes
Mar 21, 2024
| @@ -45,6 +45,8 @@ export interface APIRequestContext { | |||
| */ | |||
| export interface GlobalOptions extends MethodOptions { | |||
| auth?: GoogleAuth | OAuth2Client | BaseExternalAccountClient | string; | |||
| universeDomain?: string; | |||
There was a problem hiding this comment.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
🤖 I have created a release *beep* *boop* --- ## [7.1.0](https://togithub.com/googleapis/nodejs-googleapis-common/compare/v7.0.1...v7.1.0) (2024-03-21) ### Features * Add universe support to googleapis libraries ([#548](https://togithub.com/googleapis/nodejs-googleapis-common/issues/548)) ([dfd4b0d](https://togithub.com/googleapis/nodejs-googleapis-common/commit/dfd4b0d0a37fa9cf3f6599ba28bac817d28c96c8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a global option
universeDomain(can also be spelled asuniverse_domain). Example usage withgoogle-api-nodejs-client(for Cloud KMS):The universe domain can be also configured with
GOOGLE_CLOUD_UNIVERSE_DOMAINenvironment variable.Note that for services which have modern libraries published to
@google-cloud/NPM organization (e.g.@google-cloud/kms), we recommend using them and not@googleapislibraries. Still adding this feature to@googleapisfor completeness.