build: make update-license script work on Windows #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
changed the title
schmidt-sebastian
force-pushed
the
mrschmidt/installscript
branch
from
4a949ab to
d16ab18
Compare
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
======================================
Coverage 87.4% 87.4%
======================================
Files 27 27
Lines 16542 16542
Branches 1151 1151
======================================
Hits 14458 14458
Misses 2078 2078
Partials 6 6Continue to review full report at Codecov.
|
dev/protos/firestore_v1_proto_api.js
Outdated
| @@ -7428,4 +7428,4 @@ $root.google = (function() { | |||
| })(); | |||
|
|
|||
| return google; | |||
| })(); | |||
| })(); | |||
There was a problem hiding this comment.
Can we have new lines back? (here and everywhere)
scripts/license.js
Outdated
|
|
||
| for (const file of process.argv.slice(2)) { | ||
| const content = fs.readFileSync(file); | ||
| fs.writeFileSync(file, `${LICENSE_HEADER}\n${content}`); |
There was a problem hiding this comment.
maybe just add \n here
alexander-fenster
approved these changes
Jan 2, 2020
|
Line breaks added. |
…s-firestore into mrschmidt/installscript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the update-license script to be a Node JS script instead of bash.
The intent is to make the script work on Windows so it can be used as part of a larger PR that will export the generated types for the GAPIC client (#849)
This PR also contains the output from running the script.