fix: increase test timeout #846
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 88.83% 88.83%
=======================================
Files 27 27
Lines 16769 16769
Branches 1156 1156
=======================================
Hits 14896 14896
Misses 1868 1868
Partials 5 5Continue to review full report at Codecov.
|
| @@ -1073,7 +1073,7 @@ describe('getAll() method', () => { | |||
| expect(actualErrorAttempts).to.deep.eq(expectedErrorAttempts); | |||
| }); | |||
| }); | |||
| }); | |||
There was a problem hiding this comment.
We normally do this.timeout(5000); inside the function, it may be more readable than this, but up to you.
There was a problem hiding this comment.
That doesn't compile for me:
test/watch.ts(865,5): error TS7041: The containing arrow function captures the global value of 'this'.
test/watch.ts(865,10): error TS7017: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
If I want to do this, I have to use function() {..} somewhere in my test initialization (e.g. in the describe call). Rather than do this, I prefer to leave it as is.
There was a problem hiding this comment.
Yes, we use function instead of arrow-style functions if we need to set this.timeout(). That's OK to leave it as is.
This should make our CI less flaky.