Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use rejected Promise for terminate() #845

Merged
merged 4 commits into from
Jan 8, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This allows us to catch the rejected Promise, rather than having it show up in test log as an unhandled exception.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2019
@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #845 into master will increase coverage by 7.97%.
The diff coverage is 55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
+ Coverage    87.4%   95.37%   +7.97%     
==========================================
  Files          27       25       -2     
  Lines       16542    15152    -1390     
  Branches     1151     1151              
==========================================
- Hits        14458    14451       -7     
+ Misses       2078      695    -1383     
  Partials        6        6
Impacted Files Coverage Δ
dev/src/v1beta1/firestore_client.ts 93.23% <0%> (ø) ⬆️
dev/src/validate.ts 97.42% <100%> (ø) ⬆️
dev/src/pool.ts 96.65% <100%> (+0.01%) ⬆️
dev/src/serializer.ts 95.18% <100%> (ø) ⬆️
dev/src/v1/firestore_admin_client.ts 89.96% <25%> (ø) ⬆️
dev/src/v1/firestore_client.ts 94.7% <66.66%> (-0.04%) ⬇️
types/firestore.d.ts
dev/src/external-modules.d.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792002f...db15605. Read the comment docs.

@schmidt-sebastian
Copy link
Contributor Author

schmidt-sebastian commented Jan 2, 2020

Sending this to wilhuff since thebrianchen is still OOOThis PR also includes the fixes + pending feedback for #833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants