Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to close channels #824

Merged
merged 8 commits into from
Dec 19, 2019
Merged

feat: add ability to close channels #824

merged 8 commits into from
Dec 19, 2019

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Dec 18, 2019 •
edited
Loading

Fixes #769.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2019
@thebrianchen thebrianchen changed the title feat: Add ability to close channels feat: add ability to close channels Dec 18, 2019
@thebrianchen thebrianchen self-assigned this Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019 •
edited
Loading

Codecov Report

Merging #824 into master will decrease coverage by 0.07%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
- Coverage   90.35%   90.27%   -0.08%     
==========================================
  Files          25       25              
  Lines        2820     2828       +8     
  Branches      707      708       +1     
==========================================
+ Hits         2548     2553       +5     
- Misses        119      122       +3     
  Partials      153      153
Impacted Files Coverage Δ
dev/src/index.ts 96.37% <0%> (-0.3%) ⬇️
dev/src/pool.ts 94.64% <71.42%> (-3.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25472e1...95a82b9. Read the comment docs.

@bcoe bcoe changed the title feat: add ability to close channels [test conventional] feat: add ability to close channels Dec 18, 2019
@bcoe bcoe changed the title [test conventional] feat: add ability to close channels feat: add ability to close channels Dec 18, 2019
schmidt-sebastian
schmidt-sebastian suggested changes Dec 19, 2019
View reviewed changes
dev/src/index.ts Outdated Show resolved Hide resolved
dev/src/index.ts Outdated Show resolved Hide resolved
dev/src/index.ts Show resolved Hide resolved
dev/src/index.ts Outdated Show resolved Hide resolved
dev/src/index.ts Outdated Show resolved Hide resolved
schmidt-sebastian
schmidt-sebastian approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. @chenbrian is going to investigate what happens to snapshot listeners when terminate() is called. If the behavior is sane, we can merge and release.

schmidt-sebastian
schmidt-sebastian approved these changes Dec 19, 2019
View reviewed changes
dev/src/index.ts Outdated Show resolved Hide resolved
@thebrianchen thebrianchen merged commit 9ef582a into master Dec 19, 2019
@thebrianchen thebrianchen deleted the bc/terminate branch December 19, 2019 23:45
@yoshi-automation yoshi-automation mentioned this pull request Jan 15, 2020
Merged
@merlinnot merlinnot mentioned this pull request Feb 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose an API to close channels
3 participants
@thebrianchen @schmidt-sebastian @googlebot