Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Un-pin @gprc/grpc-js #676

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jun 4, 2019

Reverts #668. @gprc/grpc-js released 0.4.2 which contains a fix for grpc/grpc-node#895

Fixes #661

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2019
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well pinned.

@schmidt-sebastian schmidt-sebastian changed the title Revert "deps: Pin @gprc/grpc-js to 0.4.0" deps: Un-pin @gprc/grpc-js Jun 4, 2019
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #676 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   96.03%   96.17%   +0.13%     
==========================================
  Files          20       20              
  Lines        2195     2195              
  Branches      460      460              
==========================================
+ Hits         2108     2111       +3     
+ Misses         24       22       -2     
+ Partials       63       62       -1
Impacted Files Coverage Δ
dev/src/watch.ts 97.68% <0%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4c742...33ae691. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #676 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   96.03%   96.17%   +0.13%     
==========================================
  Files          20       20              
  Lines        2195     2195              
  Branches      460      460              
==========================================
+ Hits         2108     2111       +3     
+ Misses         24       22       -2     
+ Partials       63       62       -1
Impacted Files Coverage Δ
dev/src/watch.ts 97.68% <0%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4c742...33ae691. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit 46a0e6a into master Jun 4, 2019
@schmidt-sebastian schmidt-sebastian deleted the revert-668-mrschmidt-grpc-0.4.0 branch June 19, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC-JS: Possible EventEmitter memory leak detected
3 participants