Cleanup: Enum validation #508
Closed
+90
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt-validateenumvalue
branch
from
75eb0de to
3b4af2b
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-validateenumvalue
branch
from
3b4af2b to
10dc1ab
Compare
This was referenced Dec 28, 2018
yoshi-automation
added
🚨
JustinBeckwith
added
the
needs work
|
Merged as part of #512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #512 but can be reviewed independently.
This moves the validation of acceptable "enum" values in the Query API into the shared validation.ts file. To do this, I used the validation code from the Web SDK. As this code prints the acceptable value in the error message, I removed support for non-documented API shorthands such as
=(instead of==).