Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emulator support for system tests #1813

Merged
merged 7 commits into from
Feb 15, 2023

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Jan 17, 2023

fix: emulator support for system tests. Run system tests against the emulator using: yarn system-test:grpc:emulator or yarn system-test:rest:emulator

BEGIN_COMMIT_OVERRIDE
fix: emulator support for system tests. Run system tests against the emulator using: yarn system-test:grpc:emulator or yarn system-test:rest:emulator
END_COMMIT_OVERRIDE

@MarkDuckworth MarkDuckworth requested review from a team as code owners January 17, 2023 23:02
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jan 17, 2023
@MarkDuckworth
Copy link
Contributor Author

Run system tests against the emulator using:
yarn system-test:grpc:emulator or yarn system-test:rest:emulator

dev/system-test/firestore.ts Outdated Show resolved Hide resolved
dev/system-test/firestore.ts Outdated Show resolved Hide resolved
dev/system-test/firestore.ts Show resolved Hide resolved
dev/system-test/firestore.ts Outdated Show resolved Hide resolved
@dconeybe
Copy link
Contributor

Run system tests against the emulator using: yarn system-test:grpc:emulator or yarn system-test:rest:emulator

Are you able to add these to the github actions CI?

@MarkDuckworth
Copy link
Contributor Author

@dconeybe I created a separate task to modify the CI for running system tests against the emulator. See, b/266735404

dev/system-test/firestore.ts Outdated Show resolved Hide resolved
dev/system-test/firestore.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding emulator support! It was annoying when I was working on COUNT (in the java-firestore sdk) that some tests would fail against the emulator. I just ended up ignoring those failures but it's better to have each such failure explicitly marked as not being supported in the firestore emulator. This will definitely be a benefit to future work on this sdk.

@dconeybe
Copy link
Contributor

Run system tests against the emulator using: yarn system-test:grpc:emulator or yarn system-test:rest:emulator

Can you add this information to the PR's description? That will make it much more discoverable.

@MarkDuckworth MarkDuckworth added the automerge Merge the pull request once unit tests and other checks pass. label Jan 26, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 27, 2023
@MarkDuckworth MarkDuckworth added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 31, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 31, 2023
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2023
@MarkDuckworth MarkDuckworth added the automerge Merge the pull request once unit tests and other checks pass. label Feb 15, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8aedc63 into main Feb 15, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the markduckworth/emulator-test-support branch February 15, 2023 23:54
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 15, 2023
@MarkDuckworth MarkDuckworth added the release-please:force-run To run release-please label Feb 16, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants