chore: move transaction default max retry attempts to a const #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
dev/src/index.ts
Outdated
| @@ -137,6 +137,12 @@ const CLOUD_RESOURCE_HEADER = 'google-cloud-resource-prefix'; | |||
| */ | |||
| export const MAX_REQUEST_RETRIES = 5; | |||
|
|
|||
| /*! | |||
| * The maximum number of times to attempt committing a transaction before | |||
There was a problem hiding this comment.
It's not just committing it, it is retrying the transaction as a whole. Please rephrase.
schmidt-sebastian
approved these changes
Jun 24, 2021
thebrianchen
changed the title
added 2 commits
June 24, 2021 15:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving it to a const for better visibility as part of b/147440261.