-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add read-only transactions #1541
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
307c6cc
feat: add read-only transactions
schmidt-sebastian 7ba85f6
Merge branch 'master' into mrschmidt/readonly
schmidt-sebastian ff31587
Merge branch 'master' into mrschmidt/readonly
schmidt-sebastian 731498c
Merge branch 'master' into mrschmidt/readonly
schmidt-sebastian 96fb1df
Review
schmidt-sebastian cc767f4
Merge branch 'mrschmidt/readonly' of github.com:googleapis/nodejs-fir…
schmidt-sebastian 63dc44b
Lint
schmidt-sebastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2345,6 +2345,47 @@ describe('Transaction class', () => { | |
const finalSnapshot = await ref.get(); | ||
expect(finalSnapshot.data()).to.deep.equal({first: true, second: true}); | ||
}); | ||
|
||
it('supports read-only transactions', async () => { | ||
const ref = randomCol.doc('doc'); | ||
await ref.set({foo: 'bar'}); | ||
const snapshot = await firestore.runTransaction( | ||
updateFunction => updateFunction.get(ref), | ||
{readOnly: true} | ||
); | ||
expect(snapshot.exists).to.be.true; | ||
}); | ||
|
||
it('supports read-only transactions with custom read-time', async () => { | ||
const ref = randomCol.doc('doc'); | ||
const writeResult = await ref.set({foo: 1}); | ||
await ref.set({foo: 2}); | ||
const snapshot = await firestore.runTransaction( | ||
updateFunction => updateFunction.get(ref), | ||
{readOnly: true, readTime: writeResult.writeTime} | ||
); | ||
expect(snapshot.exists).to.be.true; | ||
expect(snapshot.get('foo')).to.equal(1); | ||
}); | ||
|
||
it('fails read-only with writes', async () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. optional: verify that the tx was not retried. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Sebastian goes above and beyond" |
||
let attempts = 0; | ||
|
||
const ref = randomCol.doc('doc'); | ||
try { | ||
await firestore.runTransaction( | ||
async updateFunction => { | ||
++attempts; | ||
updateFunction.set(ref, {}); | ||
}, | ||
{readOnly: true} | ||
); | ||
expect.fail(); | ||
} catch (e) { | ||
expect(attempts).to.equal(1); | ||
expect(e.code).to.equal(Status.INVALID_ARGUMENT); | ||
} | ||
}); | ||
}); | ||
|
||
describe('WriteBatch class', () => { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: specify that read-only transactions not retried in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (might make sense for you to do a quick sanity check on the result)