Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use require() to load JSON protos #1500

Merged
merged 2 commits into from
May 7, 2021

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/73a79139-85db-471d-a219-ed6f688acc77/targets

  • To automatically regenerate this PR, check this box. (May take up to 24 hours.)

PiperOrigin-RevId: 372468161
Source-Link: googleapis/googleapis@75880c3

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
The library is regenerated with gapic-generator-typescript v1.3.1.

Committer: @alexander-fenster
PiperOrigin-RevId: 372468161

Source-Author: Google APIs <[email protected]>
Source-Date: Thu May 6 18:50:48 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 75880c3e6a6aa2597400582848e81bbbfac51dea
Source-Link: googleapis/googleapis@75880c3
@yoshi-automation yoshi-automation requested review from a team as code owners May 7, 2021 11:58
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label May 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #1500 (a2d5eab) into master (a8d5f0b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   98.52%   98.52%   -0.01%     
==========================================
  Files          33       33              
  Lines       20382    20336      -46     
  Branches     1328     1320       -8     
==========================================
- Hits        20082    20036      -46     
  Misses        295      295              
  Partials        5        5              
Impacted Files Coverage Δ
dev/src/v1/firestore_admin_client.ts 98.76% <100.00%> (-0.02%) ⬇️
dev/src/v1/firestore_client.ts 98.03% <100.00%> (-0.02%) ⬇️
dev/src/v1beta1/firestore_client.ts 97.92% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d5f0b...a2d5eab. Read the comment docs.

@alexander-fenster
Copy link
Contributor

@schmidt-sebastian Please take a look at this change. I changed the code that loads protos.json (now using require instead of fs operations), I remember you had some changes related to proto JSON files so you might need to update something in synth.py to make it work properly. Thank you!

@schmidt-sebastian
Copy link
Contributor

I re-ran the synth script and all tests pass.

@schmidt-sebastian schmidt-sebastian changed the title [CHANGE ME] Re-generated to pick up changes from googleapis. [chore: simplify Protobuf loading May 7, 2021
@schmidt-sebastian schmidt-sebastian changed the title [chore: simplify Protobuf loading chore: simplify Protobuf loading May 7, 2021
@schmidt-sebastian schmidt-sebastian changed the title chore: simplify Protobuf loading chore: use require() to load JSON protos May 7, 2021
@schmidt-sebastian schmidt-sebastian merged commit f1d78ac into master May 7, 2021
@schmidt-sebastian schmidt-sebastian deleted the autosynth-googleapis branch May 7, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants