Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for environment variable FIRESTORE_PREFER_REST #1848

Merged
merged 6 commits into from
May 15, 2023
Merged

feat: Add support for environment variable FIRESTORE_PREFER_REST #1848

merged 6 commits into from
May 15, 2023

Conversation

MarkDuckworth
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@MarkDuckworth MarkDuckworth requested review from a team as code owners May 10, 2023 20:37
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/nodejs-firestore API. labels May 10, 2023
@MarkDuckworth MarkDuckworth changed the title Add support for environment variable FIRESTORE_PREFER_REST feat: Add support for environment variable FIRESTORE_PREFER_REST May 11, 2023
dconeybe
dconeybe requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fantastic! Great test coverage and well designed. Thanks for making this improvement.

dev/src/index.ts Outdated Show resolved Hide resolved
dev/src/util.ts Outdated Show resolved Hide resolved
dev/test/index.ts Show resolved Hide resolved
dev/test/util.ts Outdated Show resolved Hide resolved
dev/test/util.ts Show resolved Hide resolved
@MarkDuckworth MarkDuckworth requested a review from dconeybe May 12, 2023 16:58
dconeybe
dconeybe requested changes May 13, 2023
View reviewed changes
dev/src/util.ts Outdated Show resolved Hide resolved
dev/src/util.ts Outdated Show resolved Hide resolved
dev/src/util.ts Outdated Show resolved Hide resolved
dev/test/index.ts Show resolved Hide resolved
dev/test/util.ts Outdated Show resolved Hide resolved
dev/test/util.ts Outdated Show resolved Hide resolved
@MarkDuckworth MarkDuckworth requested a review from dconeybe May 15, 2023 16:02
dconeybe
dconeybe requested changes May 15, 2023
View reviewed changes
dev/src/util.ts Outdated Show resolved Hide resolved
@MarkDuckworth MarkDuckworth requested a review from dconeybe May 15, 2023 19:33
@MarkDuckworth MarkDuckworth merged commit 96b1d2a into main May 15, 2023
@MarkDuckworth MarkDuckworth deleted the markduckworth/env-var-firestore-prefer-rest branch May 15, 2023 19:45
@release-please release-please bot mentioned this pull request May 15, 2023
Merged
This was referenced Jul 18, 2023
Closed
Merged
@sbhvt sbhvt mentioned this pull request Nov 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkDuckworth @dconeybe