Enable preferRest by default for functions #6146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6146 +/- ##
==========================================
+ Coverage 54.60% 54.62% +0.01%
==========================================
Files 346 346
Lines 23621 23648 +27
Branches 4859 4861 +2
==========================================
+ Hits 12899 12918 +19
- Misses 9542 9548 +6
- Partials 1180 1182 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Firestore team has added the option to use HTTP/1.1 REST transport instead of gRPC. Using REST significantly reduces cold start times by eliminating the need to load gRPC libraries with the Firestore client. With googleapis/nodejs-firestore#1848, functions developers can now enable the
preferRestoption for the Firestore SDK by setting an environment variableFIRESTORE_PREFER_RESTin the GCF runtime environment. This PR enablespreferRestby default for all functions. Note: methods that require gRPC will still cause the Firestore client to load dependent gRPC libraries.