Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Add Typescript definitions #10

Closed
moberemk opened this issue Dec 18, 2017 · 12 comments
Closed

Add Typescript definitions #10

moberemk opened this issue Dec 18, 2017 · 12 comments
Assignees
Labels
api: dialogflow Issues related to the googleapis/nodejs-dialogflow API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@moberemk
Copy link

This is less of a bug and more of a feature request; adding typescript definitions would make this library far easier to work with for Typescript users. JSDoc is nice, but code completion support with that is spotty.

@CharlesT100
Copy link

This would be really great, just in case another comment helps!

@peternann
Copy link

+100. Typescript rocks. The non-typescript-javascript world don't realise what they are missing...

@beeme1mr
Copy link

Has there been any progress on this? I've started making my own but it doesn't cover everything yet.

@miguelsilv
Copy link

@beeme1mr Could you make yours available?

@dyladan
Copy link

dyladan commented Aug 6, 2018

@moberemk @CharlesT100 @peternann @miguelsilv DefinitelyTyped/DefinitelyTyped#27899

It may not be merged because it isn't tested and it doesn't completely cover the package. (batch style calls and callback style calls are not in the typings) but it is a great start if you want to make a PR against my copy (dyladan/DefinitelyTyped) to help add these things. If not, I'll get to them when I have time.

@dyladan
Copy link

dyladan commented Aug 20, 2018

@moberemk @CharlesT100 @peternann @miguelsilv npm install --save-dev @types/dialogflow

Have a good one :)

@dyladan
Copy link

dyladan commented Aug 27, 2018

@moberemk you can probably close this ticket now. Looks like the dialogflow team doesn't hardly even look at these let alone keep them cleaned up.

@moberemk
Copy link
Author

Unfortunately true... @Beccca pinging you because this seems like it would be a dev relations question, should this be closed or is it better to leave it open as a potentially to-be-addressed feature request?

@JustinBeckwith
Copy link
Contributor

Greetings folks! It looks like the types are merged in definitely typed, so I'm going to go ahead and close this one out :) Please do let me know if y'all have any questions!

@moberemk
Copy link
Author

moberemk commented Aug 27, 2018 via email

@JustinBeckwith
Copy link
Contributor

Got it. We're much more likely to rewrite the library in TypeScript, so I filed #153 to track it!

@moberemk
Copy link
Author

That makes sense, thanks for clarifying!

@google-cloud-label-sync google-cloud-label-sync bot added the api: dialogflow Issues related to the googleapis/nodejs-dialogflow API. label Jan 31, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dialogflow Issues related to the googleapis/nodejs-dialogflow API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

8 participants