-
Notifications
You must be signed in to change notification settings - Fork 272
Add Typescript definitions #10
Comments
This would be really great, just in case another comment helps! |
+100. Typescript rocks. The non-typescript-javascript world don't realise what they are missing... |
Has there been any progress on this? I've started making my own but it doesn't cover everything yet. |
@beeme1mr Could you make yours available? |
@moberemk @CharlesT100 @peternann @miguelsilv DefinitelyTyped/DefinitelyTyped#27899 It may not be merged because it isn't tested and it doesn't completely cover the package. (batch style calls and callback style calls are not in the typings) but it is a great start if you want to make a PR against my copy (dyladan/DefinitelyTyped) to help add these things. If not, I'll get to them when I have time. |
@moberemk @CharlesT100 @peternann @miguelsilv Have a good one :) |
@moberemk you can probably close this ticket now. Looks like the dialogflow team doesn't hardly even look at these let alone keep them cleaned up. |
Unfortunately true... @Beccca pinging you because this seems like it would be a dev relations question, should this be closed or is it better to leave it open as a potentially to-be-addressed feature request? |
Greetings folks! It looks like the types are merged in definitely typed, so I'm going to go ahead and close this one out :) Please do let me know if y'all have any questions! |
I would if possible appreciate the types being added directly to the
repository, actually, if that's possible; it makes management way easier
for end users. Otherwise thanks for the clarification!
…On Mon., Aug. 27, 2018, 11:53 a.m. Justin Beckwith, < ***@***.***> wrote:
Closed #10
<#10>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACu-RcugbB8_b_eqh2nte6R7e9Dj_eHYks5uVBXtgaJpZM4RGGM2>
.
|
Got it. We're much more likely to rewrite the library in TypeScript, so I filed #153 to track it! |
That makes sense, thanks for clarifying! |
This is less of a bug and more of a feature request; adding typescript definitions would make this library far easier to work with for Typescript users. JSDoc is nice, but code completion support with that is spotty.
The text was updated successfully, but these errors were encountered: