Adds databaseId to the request options, client options and code for carrying over the client options to the request options as well as a test to make sure it actually works.

…astore into multi-db

The test should include additional checks to ensure get is running the way it is supposed to.

Since we are saving things to another datastore we need to delete the data from that datastore.

The user needs a way to get the database Id from the client so that they can keep track of their clients more easily.

Ensure that the database id gets passed all the way down to the generated layer and gets included in the request.

We should check for the existance of datastore.options so that the code doesn’t fail if they are not provided at all.

The test on kokoro is failing because in that environment a project id isn’t defined. The solution is to eliminate the get request so that a call never reaches the backend and initialize the gapic client so it can be mocked out and then catch any call that reaches the mock.

Add docs comments for newly added functions and add a test that ensures setDatabaseId works correctly.

Don’t use the same string multiple times. When the database name we are using for testing changes then we should only have to make that change in one place.

This was a typo. We want to test against the database we were using before

Add the getRequestWithDatabaseId function and change it so that it can easily be used in multiple places and the tests still pass.

The request options should contain databaseId so rename the function as appropriate.

This commit contains a comment in all the places we want to add the reqOpts change.

Add a warning because the way the assert checking was done before, the test suite was not receiving any indication of which test was failing which makes debugging really hard.

Add request ids back in all the places they are required

Add addDatabaseIdToRequest to the transaction test framework so that it can be used in the tests.

Mock out add database id for the tests in createReadStream that correspond to createReadStream.

Add the addDatabaseIdToRequest mock to the tests for every runQueryStream test so that the tests pass.

addDatabaseIdToRequest should be a default function in datastore object of request so that we don’t have to mock it out in many different places.

This reverts commit a3bdb92.

This reverts commit 7b5f902.

lint an import

This reverts commit f167ce3.

This reverts commit dd7b06c.

This reverts commit 8ba512a.

Introduce adding the databaseId in request layer again.

Importing test into the system-test folder causes the system-test command to also run the tests. Eliminate this import.

Remove setDatabaseId as it provides a way for the user to get confused about the current state of the client.

The function needs a comment to be consistent with docs.

The new util file needs a header

…into multi-db

The databaseId should be encoded on keys so that the user can write on a record by record basis

This reverts commit 0ebabd5.

Try out a new test that looks at data details

Use another datastore with key

The test should look at specific details in the key and should return the data with the right author.

Add additional checks to existing test to show default database is unaffected.

This reverts commit 6449d10.

This reverts commit e694341.

…into multi-db

# Conflicts:
#	system-test/datastore.ts

multidb-test is the name of the database set up on the project used in Github automation so we need to change this name in code to use that new database.

Currently a function is used as a passthrough to the function on the util file. This unnecessarily exposes a function to the user that they shouldn’t be concerned with.

The assertion error should bubble up to the user if we send it through the callback.

Types currently set to any should be more specific. This will help clarify the purpose of the function that is used.

The types should be more specific and the names should be more explicit and clear.

…astore into multi-db

The test case has the same lines for each secondary database key and these lines should not be repeated so we regroup them into better data structures for the job

The names of some variables were changed to align with others and code was moved so that code pertaining to the same function is grouped together

There is only one default key so we change the variable name so that it doesn’t mention 1

Refactor the hierarchy out for a cleaner test

This reverts commit 0378dea.

…into multi-db

# Conflicts:
#	src/index.ts
#	system-test/datastore.ts

In the transaction tests we add the databaseId parameter. The databaseId parameter will run tests against the secondary database.

The mocks for addDatabaseIdToRequest are not necessary for these two files since they were only useful for the way the code was written before so should be removed.

Imports that were used in old mocks no longer exist in the file so should be removed.

Parameterized testing can be added to the test/index file to test to see how the tests behave with databaseId set to the second database and without this setting too.

Parameterized testing should be used on transaction.ts. This commit adds the testing with async.

Tests need to run on the default database as well as the secondary database. This commit ensures that they do.

Parameterized testing for the system tests will ensure that tests run with the default database as well as with the secondary database.

The intent of the datastore variable in the new tests is to be the default database so that we are able to see if reads/writes affect the default or secondary database in these tests. They should not use the parameterized version of datastore.

Now that the tests don’t need to mock out adding database id function, we can inline the code that adds the database id to the request options.

Parameterized tests should have a different namespace for the second set of tests for sure so we add this prefix.

The databaseId should be moved to shared query options as discussed.

Linting was broken so that the PR could be read. Ran the linter again.