Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example region-tag for Family.js #262

Merged
merged 16 commits into from
Nov 12, 2018
Merged

Added example region-tag for Family.js #262

merged 16 commits into from
Nov 12, 2018

Conversation

vijay-qlogic
Copy link
Contributor

Fixes #157 for family.js (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2018
@codecov
Copy link

codecov bot commented Aug 1, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3886233). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #262   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     10           
  Lines             ?   1281           
  Branches          ?      0           
=======================================
  Hits              ?   1281           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/family.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3886233...8eeff5c. Read the comment docs.

@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-family branch from ad72fc3 to fd4f38f Compare August 1, 2018 09:27
stephenplusplus
stephenplusplus reviewed Aug 1, 2018
View reviewed changes
samples/document-snippets/tests/family.js Outdated
});

it('should create a column family', function(done) {
familySnippets.createColmFamily(INSTANCE_ID, TABLE_ID, FAMILY_ID, err => {

This comment was marked as spam.

Sign in to view

stephenplusplus
stephenplusplus reviewed Aug 1, 2018
View reviewed changes
samples/document-snippets/family.js Outdated
.then(result => {
const family = result[0];
// let apiResponse = result[1];
callback(null, family);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-family branch 3 times, most recently from 26384d3 to ba03406 Compare August 9, 2018 06:21
@ghost ghost assigned sduskis Aug 10, 2018
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-family branch from 9c89117 to 1a8fbaf Compare August 13, 2018 17:00
stephenplusplus
stephenplusplus previously requested changes Aug 15, 2018
View reviewed changes
samples/document-snippets/family.js Outdated
// const apiResponse = result[1];
})
.catch(err => {
// handle error

This comment was marked as spam.

Sign in to view

samples/document-snippets/family.js Outdated
// [END bigtable_get_family_meta]
callback();
},
setMetaData: (instanceId, tableId, familyId, callback) => {

This comment was marked as spam.

Sign in to view

samples/document-snippets/family.js Outdated
// [END bigtable_get_family]
callback();
},
getMetaData: (instanceId, tableId, familyId, callback) => {

This comment was marked as spam.

Sign in to view

samples/document-snippets/family.js Outdated
const table = instance.table(tableId);
const family = table.family(familyId);
// [START bigtable_set_family_meta]
var metadata = {

This comment was marked as spam.

Sign in to view

samples/document-snippets/tests/family.js Outdated
@@ -0,0 +1,75 @@
/**
* Copyright 2016 Google Inc. All Rights Reserved.

This comment was marked as spam.

Sign in to view

samples/document-snippets/tests/family.js Outdated
familySnippets.getFamily(INSTANCE_ID, TABLE_ID, FAMILY_ID, done);
});

it('should get family meta-data', function(done) {

This comment was marked as spam.

Sign in to view

samples/document-snippets/tests/family.js Outdated
familySnippets.getMetaData(INSTANCE_ID, TABLE_ID, FAMILY_ID, done);
});

it('should set family meta-data', function(done) {

This comment was marked as spam.

Sign in to view

@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-family branch 2 times, most recently from f916a56 to 07ba77d Compare August 20, 2018 17:31
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-family branch 3 times, most recently from 01edd6f to 3763d72 Compare August 31, 2018 17:33
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-family branch from 3763d72 to 308d9ff Compare September 5, 2018 17:59
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-family branch from 1b1e028 to 7a94e77 Compare October 5, 2018 11:50
sduskis
sduskis suggested changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@sduskis sduskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. Let's keep the documentation consistent, and include the @require in the docs, even though we didn't have that before.

samples/document-snippets/family.js Outdated
const instance = bigtable.instance(instanceId);
const table = instance.table(tableId);
const family = table.family(familyId);
// [START bigtable_create_family]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

samples/document-snippets/family.js Outdated
const table = instance.table(tableId);
const family = table.family(familyId);

// [START bigtable_exists_family]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@sduskis sduskis mentioned this pull request Oct 12, 2018
Closed
@sduskis
Copy link
Contributor

sduskis commented Nov 2, 2018

@vijay-qlogic, can you please address the comments?

@sduskis
Copy link
Contributor

sduskis commented Nov 9, 2018

@stephenplusplus, can we move forward with this PR?

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@sduskis sduskis merged commit 41d6d68 into googleapis:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

@stephenplusplus stephenplusplus stephenplusplus left review comments

Assignees

@sduskis sduskis

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vijay-qlogic @sduskis @stephenplusplus @googlebot @kokoro-team