Added @example tags to src/table.js #239
Conversation
googlebot
added
the
cla: yes
vijay-qlogic
changed the title
|
@vijay-qlogic: Please fix the errors. |
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 10
Lines ? 1281
Branches ? 0
=======================================
Hits ? 1281
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
|
@vijay-qlogic, please fix lint. |
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
from
3dad6f6 to
78dde87
Compare
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
from
6cb5eba to
adfdcc6
Compare
|
@vijay-qlogic, can you please resolve the conflicts? |
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
from
f076d72 to
48e27bb
Compare
|
@sduskis conflicts resolved |
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
2 times, most recently
from
92bdaa0 to
2ab64bb
Compare
|
The samples should be basically what the comments were. They should not be full examples that include printlns. |
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
from
a17c3f1 to
94bd339
Compare
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
3 times, most recently
from
5a3edc0 to
85123d5
Compare
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
2 times, most recently
from
9ff8eac to
94d8a06
Compare
| @@ -47,57 +47,53 @@ const snippets = { | |||
| }; | |||
|
|
|||
| // creates a new Instance | |||
| instance | |||
| await instance | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -17,10 +17,10 @@ const Bigtable = require('@google-cloud/bigtable'); | |||
| const bigtable = new Bigtable(); | |||
|
|
|||
| const snippets = { | |||
| createInstance: (instanceId, clusterId, callback) => { | |||
| // [START bigtable_create_instance] | |||
| createInstance: async (instanceId, clusterId, callback) => { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
3 times, most recently
from
dbc82b2 to
a2ed241
Compare
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
from
a2ed241 to
462f3b7
Compare
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
from
552426c to
19e7ada
Compare
| callback(err); | ||
| return; | ||
| // Handle the error. | ||
| return callback(err); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| const instance = bigtable.instance(instanceId); | ||
| const caughtError = false; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| const instance = bigtable.instance(instanceId); | ||
| const caughtError = false; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| const instance = bigtable.instance(instanceId); | ||
| const caughtError = false; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Always using `require` in the snippet, and including it within the tag.
vijay-qlogic
force-pushed
the
tag-ex-comments-table
branch
from
8287a1f to
bdfc711
Compare
Fixes #157 for table.js (it's a good idea to open an issue first for discussion)