-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add conformance tests #1349
Merged
danieljbruce
merged 42 commits into
googleapis:main
from
danieljbruce:conformance-tests
Oct 12, 2023
Merged
Changes from 40 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
1ba08e6
Add conformance tests
danieljbruce aa18af6
try this and see what it does
danieljbruce a4e5c47
Revert "try this and see what it does"
danieljbruce a91f25b
Make the yaml config run node and not java
danieljbruce 11cd798
Add echo to test
danieljbruce 359d413
Add conformance to main CI pipeline instead
danieljbruce 80d5569
Add execution permissions
danieljbruce 2bb0eed
typo correction
danieljbruce bfddf98
Revert "typo correction"
danieljbruce d51206f
Revert "Add execution permissions"
danieljbruce a0dab58
Revert "Add conformance to main CI pipeline instead"
danieljbruce 16c796c
After reverts, rearrange files for best setup
danieljbruce fccb1ef
Add logs to see what it does
danieljbruce 5b49bd3
Try adding more logs
danieljbruce 8b2762a
Make sure it doesn’t get stuck
danieljbruce 63cca41
Correct conformance paths test run path
danieljbruce df1d9d9
Try without setting the proxy address
danieljbruce d5d0281
Fix path to the known failures again
danieljbruce 055e82c
Add a known failure so test will work
danieljbruce b0be854
Set the proxy address
danieljbruce 207e0c8
Add known failures based on tests that fail
danieljbruce 07c9d60
Put all the test names on one line
danieljbruce cb9f89d
Try using an ampersand to separate parameters
danieljbruce 47f280c
Revert "Try using an ampersand to separate parameters"
danieljbruce 1bb86d2
Try unit array syntax
danieljbruce 36815e7
Revert "Try unit array syntax"
danieljbruce 138d1c3
Try reordering the items in known failures
danieljbruce 21741f8
Try adding a comma
danieljbruce 0633088
Use correct delimiter syntax for known failures
danieljbruce b48c107
Add additional failures that were skipped before
danieljbruce 4cedac3
Add the last known failure
danieljbruce 010c54f
Remove output log location
danieljbruce 94e46de
Remove unecessary logging from script
danieljbruce 682431e
run the linter
danieljbruce 3a2d680
remove console logs
danieljbruce 1586be1
Merge branch 'main' into conformance-tests
danieljbruce a798431
Test on multiple versions of node
danieljbruce fd430be
Eliminate logging for debugging
danieljbruce 7d5855e
Remove pushd and popd
danieljbruce 8fb6e13
Remove known failures list of test
danieljbruce dcb3c9c
Add a cleanup operation
danieljbruce 6a381e4
Empty-Commit
danieljbruce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# Github action job to test core java library features on | ||
# downstream client libraries before they are released. | ||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
name: conformance | ||
jobs: | ||
conformance: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node: [ 14, 16, 18, 20 ] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@v3 | ||
with: | ||
repository: googleapis/cloud-bigtable-clients-test | ||
ref: main | ||
path: cloud-bigtable-clients-test | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ matrix.node }} | ||
- uses: actions/setup-go@v4 | ||
with: | ||
go-version: '>=1.20.2' | ||
- run: chmod +x .kokoro/conformance.sh | ||
- run: npm install | ||
- run: go version | ||
- run: .kokoro/conformance.sh |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? Looks like a duplicate of the step below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet it's not needed, but I'm not completely sure. The PR in Java has this twice so I figured there must be a reason it is there https://github.com/googleapis/java-bigtable/pull/1699/files. I'll investigate further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been informed by @liujiongxin this check is probably for the Java client repo itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that makes sense. I forgot there were two repos involved!