Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add conformance tests #1349

Merged
merged 42 commits into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
1ba08e6
Add conformance tests
danieljbruce Oct 3, 2023
aa18af6
try this and see what it does
danieljbruce Oct 3, 2023
a4e5c47
Revert "try this and see what it does"
danieljbruce Oct 3, 2023
a91f25b
Make the yaml config run node and not java
danieljbruce Oct 3, 2023
11cd798
Add echo to test
danieljbruce Oct 3, 2023
359d413
Add conformance to main CI pipeline instead
danieljbruce Oct 3, 2023
80d5569
Add execution permissions
danieljbruce Oct 3, 2023
2bb0eed
typo correction
danieljbruce Oct 3, 2023
bfddf98
Revert "typo correction"
danieljbruce Oct 4, 2023
d51206f
Revert "Add execution permissions"
danieljbruce Oct 4, 2023
a0dab58
Revert "Add conformance to main CI pipeline instead"
danieljbruce Oct 4, 2023
16c796c
After reverts, rearrange files for best setup
danieljbruce Oct 4, 2023
fccb1ef
Add logs to see what it does
danieljbruce Oct 4, 2023
5b49bd3
Try adding more logs
danieljbruce Oct 4, 2023
8b2762a
Make sure it doesn’t get stuck
danieljbruce Oct 4, 2023
63cca41
Correct conformance paths test run path
danieljbruce Oct 4, 2023
df1d9d9
Try without setting the proxy address
danieljbruce Oct 4, 2023
d5d0281
Fix path to the known failures again
danieljbruce Oct 4, 2023
055e82c
Add a known failure so test will work
danieljbruce Oct 4, 2023
b0be854
Set the proxy address
danieljbruce Oct 4, 2023
207e0c8
Add known failures based on tests that fail
danieljbruce Oct 4, 2023
07c9d60
Put all the test names on one line
danieljbruce Oct 4, 2023
cb9f89d
Try using an ampersand to separate parameters
danieljbruce Oct 4, 2023
47f280c
Revert "Try using an ampersand to separate parameters"
danieljbruce Oct 4, 2023
1bb86d2
Try unit array syntax
danieljbruce Oct 4, 2023
36815e7
Revert "Try unit array syntax"
danieljbruce Oct 4, 2023
138d1c3
Try reordering the items in known failures
danieljbruce Oct 4, 2023
21741f8
Try adding a comma
danieljbruce Oct 4, 2023
0633088
Use correct delimiter syntax for known failures
danieljbruce Oct 4, 2023
b48c107
Add additional failures that were skipped before
danieljbruce Oct 4, 2023
4cedac3
Add the last known failure
danieljbruce Oct 4, 2023
010c54f
Remove output log location
danieljbruce Oct 4, 2023
94e46de
Remove unecessary logging from script
danieljbruce Oct 4, 2023
682431e
run the linter
danieljbruce Oct 4, 2023
3a2d680
remove console logs
danieljbruce Oct 4, 2023
1586be1
Merge branch 'main' into conformance-tests
danieljbruce Oct 5, 2023
a798431
Test on multiple versions of node
danieljbruce Oct 5, 2023
fd430be
Eliminate logging for debugging
danieljbruce Oct 6, 2023
7d5855e
Remove pushd and popd
danieljbruce Oct 6, 2023
8fb6e13
Remove known failures list of test
danieljbruce Oct 10, 2023
dcb3c9c
Add a cleanup operation
danieljbruce Oct 11, 2023
6a381e4
Empty-Commit
danieljbruce Oct 12, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions .github/workflows/conformance.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# Github action job to test core java library features on
# downstream client libraries before they are released.
on:
push:
branches:
- main
pull_request:
name: conformance
jobs:
conformance:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 14, 16, 18, 20 ]
steps:
- uses: actions/checkout@v3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? Looks like a duplicate of the step below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet it's not needed, but I'm not completely sure. The PR in Java has this twice so I figured there must be a reason it is there https://github.com/googleapis/java-bigtable/pull/1699/files. I'll investigate further.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been informed by @liujiongxin this check is probably for the Java client repo itself.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that makes sense. I forgot there were two repos involved!

- uses: actions/checkout@v3
with:
repository: googleapis/cloud-bigtable-clients-test
ref: main
path: cloud-bigtable-clients-test
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- uses: actions/setup-go@v4
with:
go-version: '>=1.20.2'
- run: chmod +x .kokoro/conformance.sh
- run: npm install
- run: go version
- run: .kokoro/conformance.sh
40 changes: 40 additions & 0 deletions .kokoro/conformance.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading