build!: update library to use Node 12

.github/sync-repo-settings.yaml

@@ -9,9 +9,9 @@ branchProtectionRules:
       - "ci/kokoro: System test"
       - docs
       - lint
-      - test (10)
       - test (12)
       - test (14)
+      - test (16)
       - cla/google
       - windows
       - OwlBot Post Processor

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [10, 12, 14]
+        node: [12, 14, 16]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

package.json

@@ -53,7 +53,7 @@
     "dot-prop": "^6.0.0",
     "escape-string-regexp": "^4.0.0",
     "extend": "^3.0.2",
-    "google-gax": "^2.29.5",
+    "google-gax": "^3.0.1",
     "grpc-gcp": "0.4.2",
     "is": "^3.0.1",
     "is-utf8": "^0.2.1",
@@ -75,24 +75,24 @@
     "@types/uuid": "^8.0.0",
     "c8": "^7.1.0",
     "codecov": "^3.6.5",
-    "gts": "^3.0.0",
+    "gts": "^3.1.0",
     "jsdoc": "^3.6.3",
     "jsdoc-fresh": "^1.0.2",
     "jsdoc-region-tag": "^1.0.4",
     "linkinator": "^2.0.3",
-    "mocha": "^8.0.0",
+    "mocha": "^9.2.2",
     "null-loader": "^4.0.0",
     "p-queue": "^6.0.2",
     "pack-n-play": "^1.0.0-2",
     "proxyquire": "^2.0.0",
     "sinon": "^14.0.0",
     "ts-loader": "^9.0.0",
-    "typescript": "^3.8.3",
+    "typescript": "^4.6.4",
     "uuid": "^8.0.0",
     "webpack": "^5.0.0",
     "webpack-cli": "^4.0.0"
   },
   "engines": {
-    "node": ">=10"
+    "node": ">=12.0.0"
   }
 }

samples/package.json

@@ -11,7 +11,7 @@
     "api-reference-doc-snippets/*.js"
   ],
   "engines": {
-    "node": ">=12"
+    "node": ">=12.0.0"
   },
   "dependencies": {
     "@google-cloud/bigtable": "^3.12.0",

src/cluster.ts

@@ -89,7 +89,7 @@ export interface BasicClusterConfig {
 }
 
 export interface CreateBackupConfig extends ModifiableBackupFields {
-  table: string | Table;
+  table?: string | Table;
   gaxOptions?: CallOptions;
 }
 
@@ -487,13 +487,13 @@ Please use the format 'my-cluster' or '${instance.name}/clusters/my-cluster'.`);
 
     const reqOpts: google.bigtable.admin.v2.IListBackupsRequest = {
       parent: this.name,
-      pageSize: gaxOpts.pageSize,
-      pageToken: gaxOpts.pageToken,
+      pageSize: (gaxOpts as GetBackupsOptions).pageSize,
+      pageToken: (gaxOpts as GetBackupsOptions).pageToken,
       ...options,
     };
 
-    delete gaxOpts.pageSize;
-    delete gaxOpts.pageToken;
+    delete (gaxOpts as GetBackupsOptions).pageSize;
+    delete (gaxOpts as GetBackupsOptions).pageToken;
     delete (reqOpts as CallOptions).autoPaginate;
     delete (reqOpts as GetBackupsOptions).gaxOptions;
 

src/instance.ts

@@ -703,15 +703,15 @@ Please use the format 'my-instance' or '${bigtable.projectName}/instances/my-ins
       parent: this.name,
     };
 
-    if (is.number(gaxOpts.pageSize)) {
-      reqOpts.pageSize = gaxOpts.pageSize;
+    if (is.number((gaxOpts as GetBackupsOptions).pageSize)) {
+      reqOpts.pageSize = (gaxOpts as GetBackupsOptions).pageSize;
     }
-    delete gaxOpts.pageSize;
+    delete (gaxOpts as GetBackupsOptions).pageSize;
 
-    if (gaxOpts.pageToken) {
-      reqOpts.pageToken = gaxOpts.pageToken;
+    if ((gaxOpts as GetBackupsOptions).pageToken) {
+      reqOpts.pageToken = (gaxOpts as GetBackupsOptions).pageToken;
     }
-    delete gaxOpts.pageToken;
+    delete (gaxOpts as GetBackupsOptions).pageToken;
 
     this.bigtable.request<google.bigtable.admin.v2.IAppProfile[]>(
       {
@@ -777,15 +777,15 @@ Please use the format 'my-instance' or '${bigtable.projectName}/instances/my-ins
     };
     const gaxOpts = extend(true, {}, gaxOptions);
 
-    if (is.number(gaxOpts.pageSize)) {
-      reqOpts.pageSize = gaxOpts.pageSize;
+    if (is.number((gaxOpts as GetBackupsOptions).pageSize)) {
+      reqOpts.pageSize = (gaxOpts as GetBackupsOptions).pageSize;
     }
-    delete gaxOpts.pageSize;
+    delete (gaxOpts as GetBackupsOptions).pageSize;
 
-    if (gaxOpts.pageToken) {
-      reqOpts.pageToken = gaxOpts.pageToken;
+    if ((gaxOpts as GetBackupsOptions).pageToken) {
+      reqOpts.pageToken = (gaxOpts as GetBackupsOptions).pageToken;
     }
-    delete gaxOpts.pageToken;
+    delete (gaxOpts as GetBackupsOptions).pageToken;
 
     // eslint-disable-next-line @typescript-eslint/no-this-alias
     const self = this;
@@ -1103,13 +1103,13 @@ Please use the format 'my-instance' or '${bigtable.projectName}/instances/my-ins
       reqOpts = extend(
         {},
         {
-          pageSize: gaxOpts.pageSize,
-          pageToken: gaxOpts.pageToken,
+          pageSize: (gaxOpts as GetBackupsOptions).pageSize,
+          pageToken: (gaxOpts as GetBackupsOptions).pageToken,
         },
         reqOpts
       );
-      delete gaxOpts.pageSize;
-      delete gaxOpts.pageToken;
+      delete (gaxOpts as GetBackupsOptions).pageSize;
+      delete (gaxOpts as GetBackupsOptions).pageToken;
     }
 
     delete (reqOpts as GetTablesOptions).gaxOptions;
@@ -1184,13 +1184,13 @@ Please use the format 'my-instance' or '${bigtable.projectName}/instances/my-ins
       reqOpts = extend(
         {},
         {
-          pageSize: gaxOpts.pageSize,
-          pageToken: gaxOpts.pageToken,
+          pageSize: (gaxOpts as GetBackupsOptions).pageSize,
+          pageToken: (gaxOpts as GetBackupsOptions).pageToken,
         },
         reqOpts
       );
-      delete gaxOpts.pageSize;
-      delete gaxOpts.pageToken;
+      delete (gaxOpts as GetBackupsOptions).pageSize;
+      delete (gaxOpts as GetBackupsOptions).pageToken;
     }
 
     // eslint-disable-next-line @typescript-eslint/no-this-alias

system-test/bigtable.ts

@@ -279,7 +279,11 @@ describe('Bigtable', () => {
         await operation.promise();
         throw new Error('Cluster creation should not have succeeded');
       } catch (e) {
-        assert(e.message.includes('default keys and CMEKs are not allowed'));
+        assert(
+          (e as Error).message.includes(
+            'default keys and CMEKs are not allowed'
+          )
+        );
       }
     });
   });
@@ -913,7 +917,7 @@ describe('Bigtable', () => {
         ];
         await TABLE.insert(entries);
         const rows: Row[] = [];
-        await new Promise((resolve, reject) => {
+        await new Promise<void>((resolve, reject) => {
           const stream = TABLE.createReadStream()
             .on('error', reject)
             .on('data', row => {

system-test/install.ts

@@ -50,8 +50,8 @@ describe('📦 pack-n-play test', () => {
       await packNTest(options);
     } catch (e) {
       // all of the actionable information is on the output attribute
-      if (e.output) {
-        e.message += 'output: ' + e.output;
+      if ((e as any).output) {
+        (e as any).message += 'output: ' + (e as any).output;
       }
       throw e;
     }

test/cluster.ts

@@ -20,6 +20,13 @@ import {PassThrough, Readable} from 'stream';
 import {CallOptions} from 'google-gax';
 import {PreciseDate} from '@google-cloud/precise-date';
 
+export interface Options {
+  nodes?: Number;
+  gaxOptions?: {
+    timeout: number;
+  };
+}
+
 let promisified = false;
 const fakePromisify = Object.assign({}, promisify, {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -987,7 +994,7 @@ describe('Bigtable/Cluster', () => {
         defaultStorageType: 'exellent_type',
       };
 
-      const expectedReqOpts = Object.assign(
+      const expectedReqOpts: Options = Object.assign(
         {},
         {name: CLUSTER_NAME, serveNodes: options.nodes},
         options