Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix createReadStream retry from sending a full table scan #1026

Merged
merged 5 commits into from
Mar 16, 2022
Merged

fix: fix createReadStream retry from sending a full table scan #1026

merged 5 commits into from
Mar 16, 2022

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Mar 15, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mutianf mutianf requested review from a team as code owners March 15, 2022 13:46
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Mar 15, 2022
igorbernstein2
igorbernstein2 requested changes Mar 15, 2022
View reviewed changes
src/table.ts Outdated Show resolved Hide resolved
src/table.ts Show resolved Hide resolved
src/table.ts Show resolved Hide resolved
src/table.ts Show resolved Hide resolved
src/table.ts Show resolved Hide resolved
src/table.ts Outdated Show resolved Hide resolved
src/table.ts Outdated Show resolved Hide resolved
src/table.ts Show resolved Hide resolved
danieljbruce
danieljbruce reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about the conditions that result in a full table scan.

src/table.ts Outdated Show resolved Hide resolved
danieljbruce
danieljbruce reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/table.ts Outdated Show resolved Hide resolved
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2022
igorbernstein2
igorbernstein2 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. after the buffer end check

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2022
igorbernstein2
igorbernstein2 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mutianf mutianf merged commit f926992 into googleapis:main Mar 16, 2022
@release-please release-please bot mentioned this pull request Mar 16, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 16, 2022
@release-please
chore(main): release 3.9.3 (#1028)
2576d14 
🤖 I have created a release *beep* *boop*
---


### [3.9.3](v3.9.2...v3.9.3) (2022-03-16)


### Bug Fixes

* fix createReadStream retry from sending a full table scan ([#1026](#1026)) ([f926992](f926992))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@mutianf mutianf deleted the retry branch December 2, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljbruce danieljbruce danieljbruce left review comments

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mutianf @danieljbruce @igorbernstein2 @yoshi-kokoro