Enable no-var in eslint (#304)

.eslintrc.yml

@@ -11,3 +11,4 @@ rules:
   block-scoped-var: error
   eqeqeq: error
   no-warning-comments: warn
+  no-var: error

samples/hello-world/index.js

@@ -26,7 +26,7 @@ if (!GCLOUD_PROJECT) {
   throw new Error('Environment variables GCLOUD_PROJECT must be set!');
 }
 
-var bigtableOptions = {
+let bigtableOptions = {
   projectId: GCLOUD_PROJECT,
 };
 

samples/hello-world/index.v6.js

@@ -28,7 +28,7 @@ if (!GCLOUD_PROJECT) {
   throw new Error('Environment variables GCLOUD_PROJECT must be set!');
 }
 
-var bigtableOptions = {
+let bigtableOptions = {
   projectId: GCLOUD_PROJECT,
 };
 

samples/instances.js

@@ -23,7 +23,7 @@ if (!GCLOUD_PROJECT) {
   throw new Error('Environment variables GCLOUD_PROJECT must be set!');
 }
 
-var bigtableOptions = {
+let bigtableOptions = {
   projectId: GCLOUD_PROJECT,
 };
 

samples/quickstart.js

@@ -31,7 +31,7 @@ if (!GCLOUD_PROJECT) {
 
 (async () => {
   try {
-    var bigtableOptions = {
+    let bigtableOptions = {
       projectId: GCLOUD_PROJECT,
     };
 

samples/tableadmin.js

@@ -23,7 +23,7 @@ if (!GCLOUD_PROJECT) {
   throw new Error('Environment variables GCLOUD_PROJECT must be set!');
 }
 
-var bigtableOptions = {
+let bigtableOptions = {
   projectId: GCLOUD_PROJECT,
 };
 

src/app-profile.js

@@ -38,7 +38,7 @@ class AppProfile {
     this.bigtable = instance.bigtable;
     this.instance = instance;
 
-    var name;
+    let name;
 
     if (id.includes('/')) {
       if (id.startsWith(`${instance.name}/appProfiles/`)) {

src/cluster.js

@@ -35,7 +35,7 @@ class Cluster {
     this.bigtable = instance.bigtable;
     this.instance = instance;
 
-    var name;
+    let name;
 
     if (id.includes('/')) {
       if (id.startsWith(`${instance.name}/clusters/`)) {

src/family.js

@@ -48,7 +48,7 @@ class Family {
     this.bigtable = table.bigtable;
     this.table = table;
 
-    var name;
+    let name;
     if (id.includes('/')) {
       if (id.startsWith(`${table.name}/columnFamilies/`)) {
         name = id;

src/instance.js

@@ -43,7 +43,7 @@ class Instance {
   constructor(bigtable, id) {
     this.bigtable = bigtable;
 
-    var name;
+    let name;
     if (id.includes('/')) {
       if (id.startsWith(`${bigtable.projectName}/instances/`)) {
         name = id;

src/table.js

@@ -52,7 +52,7 @@ class Table {
     this.bigtable = instance.bigtable;
     this.instance = instance;
 
-    var name;
+    let name;
 
     if (id.includes('/')) {
       if (id.startsWith(`${instance.name}/tables/`)) {

src/v2/bigtable_instance_admin_client.js

@@ -74,13 +74,13 @@ class BigtableInstanceAdminClient {
     // Create a `gaxGrpc` object, with any grpc-specific options
     // sent to the client.
     opts.scopes = this.constructor.scopes;
-    var gaxGrpc = new gax.GrpcClient(opts);
+    let gaxGrpc = new gax.GrpcClient(opts);
 
     // Save the auth object to the client, for use by other methods.
     this.auth = gaxGrpc.auth;
 
     // Determine the client header string.
-    var clientHeader = [
+    let clientHeader = [
       `gl-node/${process.version.node}`,
       `grpc/${gaxGrpc.grpcVersion}`,
       `gax/${gax.version}`,
@@ -91,7 +91,7 @@ class BigtableInstanceAdminClient {
     }
 
     // Load the applicable protos.
-    var protos = merge(
+    let protos = merge(
       {},
       gaxGrpc.loadProto(
         path.join(__dirname, '..', '..', 'protos'),
@@ -128,7 +128,7 @@ class BigtableInstanceAdminClient {
         'appProfiles'
       ),
     };
-    var protoFilesRoot = new gax.GoogleProtoFilesRoot();
+    let protoFilesRoot = new gax.GoogleProtoFilesRoot();
     protoFilesRoot = protobuf.loadSync(
       path.join(
         __dirname,
@@ -148,34 +148,34 @@ class BigtableInstanceAdminClient {
       grpc: gaxGrpc.grpc,
     }).operationsClient(opts);
 
-    var createInstanceResponse = protoFilesRoot.lookup(
+    let createInstanceResponse = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.Instance'
     );
-    var createInstanceMetadata = protoFilesRoot.lookup(
+    let createInstanceMetadata = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.CreateInstanceMetadata'
     );
-    var partialUpdateInstanceResponse = protoFilesRoot.lookup(
+    let partialUpdateInstanceResponse = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.Instance'
     );
-    var partialUpdateInstanceMetadata = protoFilesRoot.lookup(
+    let partialUpdateInstanceMetadata = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.UpdateInstanceMetadata'
     );
-    var createClusterResponse = protoFilesRoot.lookup(
+    let createClusterResponse = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.Cluster'
     );
-    var createClusterMetadata = protoFilesRoot.lookup(
+    let createClusterMetadata = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.CreateClusterMetadata'
     );
-    var updateClusterResponse = protoFilesRoot.lookup(
+    let updateClusterResponse = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.Cluster'
     );
-    var updateClusterMetadata = protoFilesRoot.lookup(
+    let updateClusterMetadata = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.UpdateClusterMetadata'
     );
-    var updateAppProfileResponse = protoFilesRoot.lookup(
+    let updateAppProfileResponse = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.AppProfile'
     );
-    var updateAppProfileMetadata = protoFilesRoot.lookup(
+    let updateAppProfileMetadata = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.UpdateAppProfileMetadata'
     );
 
@@ -210,7 +210,7 @@ class BigtableInstanceAdminClient {
     };
 
     // Put together the default options sent with requests.
-    var defaults = gaxGrpc.constructSettings(
+    let defaults = gaxGrpc.constructSettings(
       'google.bigtable.admin.v2.BigtableInstanceAdmin',
       gapicConfig,
       opts.clientConfig,
@@ -224,14 +224,14 @@ class BigtableInstanceAdminClient {
 
     // Put together the "service stub" for
     // google.bigtable.admin.v2.BigtableInstanceAdmin.
-    var bigtableInstanceAdminStub = gaxGrpc.createStub(
+    let bigtableInstanceAdminStub = gaxGrpc.createStub(
       protos.google.bigtable.admin.v2.BigtableInstanceAdmin,
       opts
     );
 
     // Iterate over each of the methods that the service provides
     // and create an API call method for each.
-    var bigtableInstanceAdminStubMethods = [
+    let bigtableInstanceAdminStubMethods = [
       'createInstance',
       'getInstance',
       'listInstances',
@@ -257,7 +257,7 @@ class BigtableInstanceAdminClient {
         bigtableInstanceAdminStub.then(
           stub =>
             function() {
-              var args = Array.prototype.slice.call(arguments, 0);
+              let args = Array.prototype.slice.call(arguments, 0);
               return stub[methodName].apply(stub, args);
             }
         ),

src/v2/bigtable_table_admin_client.js

@@ -76,13 +76,13 @@ class BigtableTableAdminClient {
     // Create a `gaxGrpc` object, with any grpc-specific options
     // sent to the client.
     opts.scopes = this.constructor.scopes;
-    var gaxGrpc = new gax.GrpcClient(opts);
+    let gaxGrpc = new gax.GrpcClient(opts);
 
     // Save the auth object to the client, for use by other methods.
     this.auth = gaxGrpc.auth;
 
     // Determine the client header string.
-    var clientHeader = [
+    let clientHeader = [
       `gl-node/${process.version.node}`,
       `grpc/${gaxGrpc.grpcVersion}`,
       `gax/${gax.version}`,
@@ -93,7 +93,7 @@ class BigtableTableAdminClient {
     }
 
     // Load the applicable protos.
-    var protos = merge(
+    let protos = merge(
       {},
       gaxGrpc.loadProto(
         path.join(__dirname, '..', '..', 'protos'),
@@ -134,7 +134,7 @@ class BigtableTableAdminClient {
         'snapshots'
       ),
     };
-    var protoFilesRoot = new gax.GoogleProtoFilesRoot();
+    let protoFilesRoot = new gax.GoogleProtoFilesRoot();
     protoFilesRoot = protobuf.loadSync(
       path.join(
         __dirname,
@@ -154,16 +154,16 @@ class BigtableTableAdminClient {
       grpc: gaxGrpc.grpc,
     }).operationsClient(opts);
 
-    var createTableFromSnapshotResponse = protoFilesRoot.lookup(
+    let createTableFromSnapshotResponse = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.Table'
     );
-    var createTableFromSnapshotMetadata = protoFilesRoot.lookup(
+    let createTableFromSnapshotMetadata = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.CreateTableFromSnapshotMetadata'
     );
-    var snapshotTableResponse = protoFilesRoot.lookup(
+    let snapshotTableResponse = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.Snapshot'
     );
-    var snapshotTableMetadata = protoFilesRoot.lookup(
+    let snapshotTableMetadata = protoFilesRoot.lookup(
       'google.bigtable.admin.v2.SnapshotTableMetadata'
     );
 
@@ -185,7 +185,7 @@ class BigtableTableAdminClient {
     };
 
     // Put together the default options sent with requests.
-    var defaults = gaxGrpc.constructSettings(
+    let defaults = gaxGrpc.constructSettings(
       'google.bigtable.admin.v2.BigtableTableAdmin',
       gapicConfig,
       opts.clientConfig,
@@ -199,14 +199,14 @@ class BigtableTableAdminClient {
 
     // Put together the "service stub" for
     // google.bigtable.admin.v2.BigtableTableAdmin.
-    var bigtableTableAdminStub = gaxGrpc.createStub(
+    let bigtableTableAdminStub = gaxGrpc.createStub(
       protos.google.bigtable.admin.v2.BigtableTableAdmin,
       opts
     );
 
     // Iterate over each of the methods that the service provides
     // and create an API call method for each.
-    var bigtableTableAdminStubMethods = [
+    let bigtableTableAdminStubMethods = [
       'createTable',
       'createTableFromSnapshot',
       'listTables',
@@ -226,7 +226,7 @@ class BigtableTableAdminClient {
         bigtableTableAdminStub.then(
           stub =>
             function() {
-              var args = Array.prototype.slice.call(arguments, 0);
+              let args = Array.prototype.slice.call(arguments, 0);
               return stub[methodName].apply(stub, args);
             }
         ),