feat: partial metadata projection #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 2, 2023 16:27
…t_partial_metadata_projection updating changes on main branch
product-auto-label
bot
added
size: s
alvarowolfx
requested changes
Aug 11, 2023
system-test/bigquery.ts
Outdated
| @@ -888,9 +887,25 @@ describe('BigQuery', () => { | |||
| const description = 'catsandstuff'; | |||
| await table.setMetadata({description}); | |||
| const [metadata] = await table.getMetadata(); | |||
| const metadataProps = Object.values(metadata); | |||
| assert.strictEqual(metadataProps.length, 18); | |||
There was a problem hiding this comment.
I think checking for the number of attributes here can lead the test to be flaky in the long term, as every time that the service team adds a new field, the test is going to break.
system-test/bigquery.ts
Outdated
| Object.keys(basicMetadata.metadata) | ||
| ); | ||
|
|
||
| assert.strictEqual(basicMetadataProps.length, 10); |
There was a problem hiding this comment.
Same comment around testing for the amount of fields
alvarowolfx
changed the title
I'm already checking against |
alvarowolfx
approved these changes
Aug 15, 2023
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
This PR updates the documentation to specify how to get a partial metadata projection via the
table.get()method, and clarified the difference between this method andtable.getMetadata()in terms of being selective about metadata retrieved. A system test for this usage oftable.get()has been added, as well as an expansion of thetable.getMetadata()system test to help illustrate the differences between these two methods. This PR reflects an update to the BigQuery API across all languages, not a GH issue for this repo.