Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emit connection event for a StreamConnection #533

Merged
merged 3 commits into from
Jan 9, 2025
Merged

feat: emit connection event for a StreamConnection #533

merged 3 commits into from
Jan 9, 2025

Conversation

alvarowolfx
Copy link
Contributor

Fixes #529 🦕
Supersedes #530

@alvarowolfx alvarowolfx requested review from a team as code owners January 6, 2025 16:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels Jan 6, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 6, 2025
leahecole
leahecole reviewed Jan 6, 2025
View reviewed changes
protos/protos.d.ts Outdated Show resolved Hide resolved
protos/protos.js Outdated Show resolved Hide resolved
src/managedwriter/stream_connection.ts Show resolved Hide resolved
@alvarowolfx alvarowolfx requested a review from leahecole January 8, 2025 13:25
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jan 8, 2025
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2025
@alvarowolfx alvarowolfx added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 9, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2025
@alvarowolfx alvarowolfx mentioned this pull request Jan 9, 2025
Closed
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6688ea3 into main Jan 9, 2025
17 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 9, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the feat-emit-conn-events branch January 9, 2025 14:58
@release-please release-please bot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit close/reconnect events on StreamConnections
2 participants
@alvarowolfx @leahecole