Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: initial generation of library #1

Merged
merged 12 commits into from
Feb 20, 2020
Merged

feat!: initial generation of library #1

merged 12 commits into from
Feb 20, 2020

Conversation

steffnay
Copy link
Collaborator

@steffnay steffnay commented Jan 8, 2020 •
edited
Loading

Adds initial generation of the library.

@alexander-fenster alexander-fenster mentioned this pull request Jan 8, 2020
Merged
JustinBeckwith
JustinBeckwith suggested changes Feb 11, 2020
View reviewed changes
linkinator.config.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.repo-metadata.json Outdated Show resolved Hide resolved
samples/package.json Show resolved Hide resolved
samples/quickstart.js Outdated Show resolved Hide resolved
samples/quickstart.js Outdated Show resolved Hide resolved
samples/quickstart.js Show resolved Hide resolved
JustinBeckwith
JustinBeckwith approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for rolling with the PR feedback!

bcoe
bcoe reviewed Feb 19, 2020
View reviewed changes
samples/package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@bcoe bcoe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 20, 2020
@steffnay steffnay merged commit bd42fbd into master Feb 20, 2020
@steffnay steffnay deleted the initial-version branch February 20, 2020 21:10
@release-please release-please bot mentioned this pull request Feb 20, 2020
Merged
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@bd519c4). Click here to learn what that means.
The diff coverage is 13.97%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   13.97%           
=========================================
  Files             ?        4           
  Lines             ?     1023           
  Branches          ?        0           
=========================================
  Hits              ?      143           
  Misses            ?      880           
  Partials          ?        0
Impacted Files Coverage Δ
src/index.ts 0% <0%> (ø)
src/v1beta1/big_query_storage_client.ts 0% <0%> (ø)
src/v1beta1/index.ts 0% <0%> (ø)
samples/quickstart.js 97.27% <97.27%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd519c4...17c3755. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@bcoe bcoe bcoe approved these changes

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steffnay @bcoe @JustinBeckwith @yoshi-kokoro