Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Commit

Permalink
fix: preserve default values in x-goog-request-params header (#18)
Browse files Browse the repository at this point in the history
* chore: use gapic-generator-typescript v2.17.0

PiperOrigin-RevId: 474338479

Source-Link: googleapis/googleapis@d5d35e0

Source-Link: https://github.com/googleapis/googleapis-gen/commit/efcd3f93962a103f68f003e2a1eecde6fa216a27
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: use fully qualified request type name in tests

PiperOrigin-RevId: 475685359

Source-Link: googleapis/googleapis@7a12973

Source-Link: https://github.com/googleapis/googleapis-gen/commit/370c729e2ba062a167449c27882ba5f379c5c34d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: update repo metadata

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <[email protected]>
  • Loading branch information
3 people authored Sep 21, 2022
1 parent 4be826d commit 19c2bf9
Show file tree
Hide file tree
Showing 6 changed files with 2,241 additions and 2,582 deletions.
4 changes: 2 additions & 2 deletions .repo-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"name": "apigeeregistry",
"name_pretty": "Apigee Registry API",
"product_documentation": "https://cloud.google.com/apigee/docs/api-hub/get-started-registry-api",
"client_documentation": "https://cloud.google.com/nodejs/docs/reference/apigeeregistry/latest",
"issue_tracker": "https://github.com/googleapis/nodejs-video-transcoder/issues",
"client_documentation": "https://cloud.google.com/nodejs/docs/reference/apigee-registry/latest",
"issue_tracker": "https://github.com/googleapis/nodejs-apigee-registry/issues",
"release_level": "beta",
"language": "nodejs",
"repo": "googleapis/nodejs-apigee-registry",
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ Apache Version 2.0

See [LICENSE](https://github.com/googleapis/nodejs-apigee-registry/blob/main/LICENSE)

[client-docs]: https://cloud.google.com/nodejs/docs/reference/apigeeregistry/latest
[client-docs]: https://cloud.google.com/nodejs/docs/reference/apigee-registry/latest
[product-docs]: https://cloud.google.com/apigee/docs/api-hub/get-started-registry-api
[shell_img]: https://gstatic.com/cloudssh/images/open-btn.png
[projects]: https://console.cloud.google.com/project
Expand Down
6 changes: 3 additions & 3 deletions src/v1/provisioning_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ export class ProvisioningClient {
options.otherArgs.headers = options.otherArgs.headers || {};
options.otherArgs.headers['x-goog-request-params'] =
this._gaxModule.routingHeader.fromParams({
name: request.name || '',
name: request.name ?? '',
});
this.initialize();
return this.innerApiCalls.getInstance(request, options, callback);
Expand Down Expand Up @@ -743,7 +743,7 @@ export class ProvisioningClient {
options.otherArgs.headers = options.otherArgs.headers || {};
options.otherArgs.headers['x-goog-request-params'] =
this._gaxModule.routingHeader.fromParams({
parent: request.parent || '',
parent: request.parent ?? '',
});
this.initialize();
return this.innerApiCalls.createInstance(request, options, callback);
Expand Down Expand Up @@ -882,7 +882,7 @@ export class ProvisioningClient {
options.otherArgs.headers = options.otherArgs.headers || {};
options.otherArgs.headers['x-goog-request-params'] =
this._gaxModule.routingHeader.fromParams({
name: request.name || '',
name: request.name ?? '',
});
this.initialize();
return this.innerApiCalls.deleteInstance(request, options, callback);
Expand Down
Loading

0 comments on commit 19c2bf9

Please sign in to comment.