Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Using jose instead of jws #494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BjornTheProgrammer
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #493 🦕

This pull request would change to using jose, a cross-runtime library for web tokens, instead of jws. The significance of this has been described in the issue. But it would make most if not all googleapis available on platforms like Cloudfare workers.

BREAKING CHANGE:
There are possible breaking changes. The test had to be modified to comply with pkcs8 and 2048 bits long. I could make this support pkcs1 and convert it to pkcs8, but it looks like the actual private keys returned by Google are pkcs8, and this might've been an artifact of just testing. Verification should be done about that before hand. Additionally node support has been bumped to >= 15, as that is when the WebCrypto api's were added to node.

@BjornTheProgrammer BjornTheProgrammer requested a review from a team as a code owner October 27, 2024 05:48
Copy link

conventional-commit-lint-gcf bot commented Oct 27, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting non nodejs runtimes
1 participant