feat!: Using jose instead of jws #494
Open
+61
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #493 🦕
This pull request would change to using
jose
, a cross-runtime library for web tokens, instead ofjws
. The significance of this has been described in the issue. But it would make most if not allgoogleapis
available on platforms like Cloudfare workers.BREAKING CHANGE:
There are possible breaking changes. The test had to be modified to comply with pkcs8 and 2048 bits long. I could make this support pkcs1 and convert it to pkcs8, but it looks like the actual private keys returned by Google are pkcs8, and this might've been an artifact of just testing. Verification should be done about that before hand. Additionally node support has been bumped to >= 15, as that is when the WebCrypto api's were added to node.