-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency com.google.cloud:google-cloud-storage-control to v2.36.1-alpha #2488
chore(deps): update dependency com.google.cloud:google-cloud-storage-control to v2.36.1-alpha #2488
Conversation
@@ -44,6 +48,11 @@ If you are using Maven without the BOM, add this to your dependencies: | |||
<artifactId>google-cloud-storage</artifactId> | |||
<version>2.36.0</version> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to change this to importing the google-cloud-storage-bom
rather than using storage-control directly.
This will make it easier for customers when the library moves from alpha to beta to ga as they won't have to update their storage-control dependency, only google-cloud-storage-bom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we probably want to do the same thing for our samples modules that aren't using libraries-bom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for the sample that tells people how to use the library without the bom though?
see above: If you are using Maven without the BOM, add this to your dependencies:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that statement is meant to mean libraries-bom
, we might need to disambiguate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to release this as is but we can update it for the next release.
…control to v2.36.1-alpha
f296ef4
to
b96d421
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
/gcbrun |
This PR contains the following updates:
2.36.0-alpha
->2.36.1-alpha
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.