build: switch to using junit 5 bom (#2680)

googleapis · Aug 23, 2024 · c07ce03 · c07ce03
1 parent 3405611
commit c07ce03
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/google-cloud-storage/pom.xml b/google-cloud-storage/pom.xml
@@ -17,7 +17,6 @@
   <properties>
     <site.installationModule>google-cloud-storage</site.installationModule>
     <pubsub-proto.version>1.114.1</pubsub-proto.version>
-    <junit-platform.version>5.11.0</junit-platform.version>
   </properties>
   <dependencies>
     <dependency>
@@ -294,15 +293,14 @@
       <scope>test</scope>
     </dependency>
     <dependency>
-      <groupId>net.jqwik</groupId>
-      <artifactId>jqwik</artifactId>
-      <version>1.9.0</version>
+      <groupId>org.junit.vintage</groupId>
+      <artifactId>junit-vintage-engine</artifactId>
       <scope>test</scope>
     </dependency>
     <dependency>
-      <groupId>org.junit.vintage</groupId>
-      <artifactId>junit-vintage-engine</artifactId>
-      <version>${junit-platform.version}</version>
+      <groupId>net.jqwik</groupId>
+      <artifactId>jqwik</artifactId>
+      <version>1.9.0</version>
       <scope>test</scope>
     </dependency>
 
@@ -399,13 +397,11 @@
         <dependency>
           <groupId>org.junit.vintage</groupId>
           <artifactId>junit-vintage-engine</artifactId>
-          <version>${junit-platform.version}</version>
           <scope>test</scope>
         </dependency>
         <dependency>
           <groupId>org.junit.jupiter</groupId>
           <artifactId>junit-jupiter-engine</artifactId>
-          <version>${junit-platform.version}</version>
           <scope>test</scope>
         </dependency>
       </dependencies>

diff --git a/pom.xml b/pom.xml
@@ -66,6 +66,13 @@
         <type>pom</type>
         <scope>import</scope>
       </dependency>
+      <dependency>
+        <groupId>org.junit</groupId>
+        <artifactId>junit-bom</artifactId>
+        <version>5.11.0</version>
+        <type>pom</type>
+        <scope>import</scope>
+      </dependency>
       <!--
       Each of the following dependencies declares a dependency on opentelemtry-semconv,
       but they differ in what version. Explicitly declare the version here to break the tie.