Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: try to debug failing integrations #45

Closed
wants to merge 1 commit into from
Closed

Conversation

chingor13
Copy link
Collaborator

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 4, 2020
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #45   +/-   ##
=========================================
  Coverage     70.21%   70.21%           
  Complexity      483      483           
=========================================
  Files            29       29           
  Lines          1665     1665           
  Branches        263      263           
=========================================
  Hits           1169     1169           
  Misses          374      374           
  Partials        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4d1b2...43ca107. Read the comment docs.

@frankyn
Copy link
Member

frankyn commented Mar 14, 2020

Hi @chingor13, I was diving into #8 and found your PR.

IIUC, the issue here is that the service account used to execute tests has Project Owner role granted.
I was able to pass tests locally when my service account is only granted Project Editor role. The reason is that Project Owner has serviceusage.services.use. This lets requests succeed without having the user set a user_project as expected.

An alternative solution to this is to create a new service account for this project that only has Project Editor role.

This was encountered here as well: googleapis/google-cloud-java#3448

Totally open to discussing this more. I don't know where the service account is stored but I can help update it with a new service account credentials file to unblock this failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants