Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Noop in case there is no change in autocommit value for setAutocommit() method #2662

Merged
merged 5 commits into from
Oct 10, 2023
Merged

fix: Noop in case there is no change in autocommit value for setAutocommit() method #2662

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed5d6dc
Fix: Noop in case there is no change in autocommit value for setAutoc…
ankiaga Oct 9, 2023
e95a142
Resolved comments and Added tests
ankiaga Oct 9, 2023
41915e0
Resolved comments
ankiaga Oct 9, 2023
ee83c79
Fix formatting errors
ankiaga Oct 10, 2023
f161539
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,9 @@ public boolean isClosed() {

@Override
public void setAutocommit(boolean autocommit) {
if (isAutocommit() == autocommit) {
olavloite marked this conversation as resolved.
Show resolved Hide resolved
return;
}
ConnectionPreconditions.checkState(!isClosed(), CLOSED_ERROR_MSG);
ConnectionPreconditions.checkState(!isBatchActive(), "Cannot set autocommit while in a batch");
ConnectionPreconditions.checkState(
Expand Down
16 changes: 16 additions & 0 deletions ...e-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/ConnectionImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,22 @@ public void testExecuteSetAutocommitOff() {
}
}

@Test
public void testExecuteAutocommitNoop() {
try (ConnectionImpl subject =
createConnection(
ConnectionOptions.newBuilder()
.setCredentials(NoCredentials.getInstance())
.setUri(URI)
.build())) {
assertThat(subject.isAutocommit(), is(true));
olavloite marked this conversation as resolved.
Show resolved Hide resolved

StatementResult res = subject.execute(Statement.of("set autocommit = true"));
assertThat(res.getResultType(), is(equalTo(ResultType.NO_RESULT)));
assertThat(subject.isAutocommit(), is(true));
}
}

@Test
public void testExecuteGetAutocommit() {
try (ConnectionImpl subject =
Expand Down
Loading