-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support setting core pool size for async API in system property #2632
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,6 +63,7 @@ | |
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.concurrent.Callable; | ||
import java.util.concurrent.ScheduledExecutorService; | ||
import javax.annotation.Nonnull; | ||
import org.junit.Test; | ||
|
@@ -913,6 +914,49 @@ public void testCustomAsyncExecutorProvider() { | |
assertSame(service, options.getAsyncExecutorProvider().getExecutor()); | ||
} | ||
|
||
@Test | ||
public void testAsyncExecutorProviderCoreThreadCount() throws Exception { | ||
assertEquals(8, SpannerOptions.getDefaultAsyncExecutorProviderCoreThreadCount()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Should we add a check to ensure that the system property was originally unset? Or maybe explicitly set the property to null? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see that there is a handling of this scenario within the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added a test for both |
||
String propertyName = "SPANNER_ASYNC_NUM_CORE_THREADS"; | ||
assertEquals( | ||
Integer.valueOf(16), | ||
runWithSystemProperty( | ||
propertyName, "16", SpannerOptions::getDefaultAsyncExecutorProviderCoreThreadCount)); | ||
assertEquals( | ||
Integer.valueOf(1), | ||
runWithSystemProperty( | ||
propertyName, "1", SpannerOptions::getDefaultAsyncExecutorProviderCoreThreadCount)); | ||
assertThrows( | ||
SpannerException.class, | ||
() -> | ||
runWithSystemProperty( | ||
propertyName, | ||
"foo", | ||
SpannerOptions::getDefaultAsyncExecutorProviderCoreThreadCount)); | ||
assertThrows( | ||
SpannerException.class, | ||
() -> | ||
runWithSystemProperty( | ||
propertyName, | ||
"-1", | ||
SpannerOptions::getDefaultAsyncExecutorProviderCoreThreadCount)); | ||
} | ||
|
||
static <V> V runWithSystemProperty( | ||
String propertyName, String propertyValue, Callable<V> callable) throws Exception { | ||
String currentValue = System.getProperty(propertyName); | ||
System.setProperty(propertyName, propertyValue); | ||
try { | ||
return callable.call(); | ||
} finally { | ||
if (currentValue == null) { | ||
System.clearProperty(propertyName); | ||
} else { | ||
System.setProperty(propertyName, currentValue); | ||
} | ||
} | ||
} | ||
|
||
@Test | ||
public void testDefaultNumChannelsWithGrpcGcpExtensionEnabled() { | ||
SpannerOptions options = | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magic string!
should we maintain list of constants/enums property names?