-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gRPC-GCP channel pool as an option #1227
Merged
+569
−2
Merged
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6b58a5a
add grpc-gcp extensions
Jennnnny 9e59de1
remove local files
Jennnnny 2349c47
update read apiconfig
Jennnnny e1c55d8
update read apiconfig
Jennnnny 418da2b
Add custom pool size for GCP extension
Jennnnny 422302b
add one more entry in aip config file
Jennnnny 03815ca
Merge branch 'master' into grpc-gcp
Jennnnny 75bc079
change gcp package name
Jennnnny ea76c32
Adjust grpc-gcp package name and group
nimf 5d2afc8
Set grpc-gcp low streams watermark to 1
nimf 76332de
Add gRPC-GCP extension options to SpannerOptions
nimf f8006c4
feat: add gRPC-GCP channel pool as an option
nimf b6ccf7a
Addressed comments.
nimf 549e2fd
Merge branch 'master' into grpc-gcp
nimf 6b94299
Fixed linting issues.
nimf ea82c12
Add integration test with enabled gRPC-GCP extension
nimf ed3d4ad
Remake gRPC-GCP extension related SpannerOptions
nimf 2044798
Add ChannelUsageTest
olavloite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
...-cloud-spanner/src/main/resources/com/google/cloud/spanner/spi/v1/grpc-gcp-apiconfig.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,106 @@ | ||
{ | ||
"channelPool": { | ||
"maxSize": 3, | ||
nimf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"maxConcurrentStreamsLowWatermark": 0 | ||
}, | ||
"method": [ | ||
{ | ||
"name": ["google.spanner.v1.Spanner/CreateSession"], | ||
"affinity" : { | ||
"command": "BIND", | ||
"affinityKey": "name" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/BatchCreateSessions"], | ||
nimf marked this conversation as resolved.
Show resolved
Hide resolved
nimf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"affinity" : { | ||
"command": "BIND", | ||
"affinityKey": "session.name" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/GetSession"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "name" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/DeleteSession"], | ||
"affinity": { | ||
"command": "UNBIND", | ||
"affinityKey": "name" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/ExecuteSql"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/ExecuteBatchDml"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/ExecuteStreamingSql"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/Read"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/StreamingRead"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/BeginTransaction"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/Commit"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/PartitionRead"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/PartitionQuery"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
}, | ||
{ | ||
"name": ["google.spanner.v1.Spanner/Rollback"], | ||
"affinity": { | ||
"command": "BOUND", | ||
"affinityKey": "session" | ||
} | ||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tend to use the versions specified in java-shared-dependencies. By that, I mean we usually do NOT specify version dependencies (like here), but instead rely on the versions provided by the POM import of that repository.
Could we do the same for this artifact (if it is part of any BOMs specified in the shared dependencies)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a part of any BOMs. If I add it to the java-shared-dependencies will all the projects depending on it automatically get grpc-gcp as a dependency or they must explicitly add it to their dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They must explicitly add it to their dependencies, but they won't need to specify a version. This makes sure that we are always using compatible library versions.