fix units

googleapis · Nov 21, 2024 · fafe22a · fafe22a
1 parent 439e105
commit fafe22a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/BatchCreateSessionsSlowTest.java b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/BatchCreateSessionsSlowTest.java
@@ -194,7 +194,6 @@ public void testBatchCreateSessionsTimesOut_whenResourceExhausted() throws Excep
       List<ListenableFuture<Void>> futures = new ArrayList<>(5000);
       AtomicInteger counter = new AtomicInteger();
       for (int i = 0; i < 5000; i++) {
-        final int index = i;
         futures.add(
             service.submit(
                 () -> {

diff --git a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseClientImplTest.java b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseClientImplTest.java
@@ -2868,7 +2868,8 @@ public void testPartitionedDmlDoesNotTimeout() {
       DatabaseClient client =
           spanner.getDatabaseClient(DatabaseId.of(TEST_PROJECT, TEST_INSTANCE, TEST_DATABASE));
 
-      assertThat(spanner.getOptions().getPartitionedDmlTimeout()).isEqualTo(Duration.ofHours(2L));
+      assertThat(spanner.getOptions().getPartitionedDmlTimeoutDuration())
+          .isEqualTo(Duration.ofHours(2L));
 
       // PDML should not timeout with these settings.
       long updateCount = client.executePartitionedUpdate(UPDATE_STATEMENT);
@@ -2904,7 +2905,8 @@ public void testPartitionedDmlWithLowerTimeout() {
     try (Spanner spanner = builder.build().getService()) {
       DatabaseClient client =
           spanner.getDatabaseClient(DatabaseId.of(TEST_PROJECT, TEST_INSTANCE, TEST_DATABASE));
-      assertThat(spanner.getOptions().getPartitionedDmlTimeout()).isEqualTo(Duration.ofMillis(10L));
+      assertThat(spanner.getOptions().getPartitionedDmlTimeoutDuration())
+          .isEqualTo(Duration.ofMillis(10L));
       // PDML should time out with these settings.
       mockSpanner.setExecuteSqlExecutionTime(
           SimulatedExecutionTime.ofMinimumAndRandomTime(1000, 0));

diff --git a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java
@@ -919,15 +919,15 @@ public void testSpannerCallContextTimeoutConfigurator_WithTimeouts() {
                     inputCallContext,
                     CommitRequest.getDefaultInstance(),
                     SpannerGrpc.getCommitMethod())
-                .getTimeout())
+                .getTimeoutDuration())
         .isEqualTo(Duration.ofSeconds(2L));
     assertThat(
             configurator
                 .configure(
                     inputCallContext,
                     RollbackRequest.getDefaultInstance(),
                     SpannerGrpc.getRollbackMethod())
-                .getTimeout())
+                .getTimeoutDuration())
         .isEqualTo(Duration.ofSeconds(8L));
 
     assertNull(
@@ -941,15 +941,15 @@ public void testSpannerCallContextTimeoutConfigurator_WithTimeouts() {
                     inputCallContext,
                     ExecuteSqlRequest.getDefaultInstance(),
                     SpannerGrpc.getExecuteStreamingSqlMethod())
-                .getTimeout())
+                .getTimeoutDuration())
         .isEqualTo(Duration.ofSeconds(3L));
     assertThat(
             configurator
                 .configure(
                     inputCallContext,
                     ExecuteBatchDmlRequest.getDefaultInstance(),
                     SpannerGrpc.getExecuteBatchDmlMethod())
-                .getTimeout())
+                .getTimeoutDuration())
         .isEqualTo(Duration.ofSeconds(1L));
     assertNull(
         configurator.configure(
@@ -960,7 +960,7 @@ public void testSpannerCallContextTimeoutConfigurator_WithTimeouts() {
                     inputCallContext,
                     ReadRequest.getDefaultInstance(),
                     SpannerGrpc.getStreamingReadMethod())
-                .getTimeout())
+                .getTimeoutDuration())
         .isEqualTo(Duration.ofSeconds(7L));
 
     assertThat(
@@ -969,15 +969,15 @@ public void testSpannerCallContextTimeoutConfigurator_WithTimeouts() {
                     inputCallContext,
                     PartitionQueryRequest.getDefaultInstance(),
                     SpannerGrpc.getPartitionQueryMethod())
-                .getTimeout())
+                .getTimeoutDuration())
         .isEqualTo(Duration.ofSeconds(5L));
     assertThat(
             configurator
                 .configure(
                     inputCallContext,
                     PartitionReadRequest.getDefaultInstance(),
                     SpannerGrpc.getPartitionReadMethod())
-                .getTimeout())
+                .getTimeoutDuration())
         .isEqualTo(Duration.ofSeconds(6L));
   }