Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

fix(samples): removed region tags #531

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix(samples): removed region tags #531

merged 1 commit into from
Sep 12, 2022

Conversation

dfirova
Copy link
Contributor

@dfirova dfirova commented Sep 5, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@dfirova dfirova requested review from a team as code owners September 5, 2022 10:19
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. labels Sep 5, 2022
@snippet-bot
Copy link

snippet-bot bot commented Sep 5, 2022

Here is the summary of changes.

You are about to delete 24 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@chenlei1216
Copy link

Discussed offline, that we're not gonna use the interactive tutorial samples in cloud doc, so SGTM to remove the tags.

@Neenu1995 Neenu1995 removed their assignment Sep 12, 2022
@Neenu1995 Neenu1995 changed the title fix (samples) removed region tags. fix(samples): removed region tags. Sep 12, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 12, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022
@Neenu1995 Neenu1995 changed the title fix(samples): removed region tags. fix(samples): removed region tags Sep 12, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2022
@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2d0dd5c into googleapis:main Sep 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2022
@release-please release-please bot mentioned this pull request Sep 12, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 16, 2022
@release-please
chore(main): release 2.5.0 (#532)
53ce196 
🤖 I have created a release *beep* *boop*
---


## [2.5.0](v2.4.0...v2.5.0) (2022-09-16)


### Features

* add local inventories info to the Product resource ([8204fbc](8204fbc))
* release AttributesConfig APIs to v2 version ([8204fbc](8204fbc))
* release CompletionConfig APIs to v2 version ([8204fbc](8204fbc))
* Release Control and ServingConfig serivces to v2 version ([#522](#522)) ([8204fbc](8204fbc))


### Bug Fixes

* **samples:** Removed add time from lro. ([#530](#530)) ([541e280](541e280))
* **samples:** Removed env variables and buckets from creating bq. ([#526](#526)) ([67152a6](67152a6))
* **samples:** Removed region tags ([#531](#531)) ([2d0dd5c](2d0dd5c))


### Documentation

* Improved documentation for Fullfillment and Inventory API in ProductService ([8204fbc](8204fbc))
* minor documentation format and typo fixes ([8204fbc](8204fbc))
* **samples:** Refactoring events package ([#481](#481)) ([20d2539](20d2539))
* **samples:** Refactoring product package ([#480](#480)) ([0c39897](0c39897))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#503](#503)) ([435df1b](435df1b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#519](#519)) ([9c37ee3](9c37ee3))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#523](#523)) ([0da80f8](0da80f8))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#524](#524)) ([ecb986a](ecb986a))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#535](#535)) ([e7fa004](e7fa004))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#533](#533)) ([6236b06](6236b06))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#538](#538)) ([ab71781](ab71781))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#511](#511)) ([364b3d4](364b3d4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to meltsufin/monorepo-experiments that referenced this pull request Sep 17, 2022
@release-please
chore(main): release 2.5.0 (#532)
164b26b 
🤖 I have created a release *beep* *boop*
---


## [2.5.0](googleapis/java-retail@v2.4.0...v2.5.0) (2022-09-16)


### Features

* add local inventories info to the Product resource ([32a384d](googleapis/java-retail@32a384d))
* release AttributesConfig APIs to v2 version ([32a384d](googleapis/java-retail@32a384d))
* release CompletionConfig APIs to v2 version ([32a384d](googleapis/java-retail@32a384d))
* Release Control and ServingConfig serivces to v2 version ([#522](googleapis/java-retail#522)) ([32a384d](googleapis/java-retail@32a384d))


### Bug Fixes

* **samples:** Removed add time from lro. ([#530](googleapis/java-retail#530)) ([858b0e1](googleapis/java-retail@858b0e1))
* **samples:** Removed env variables and buckets from creating bq. ([#526](googleapis/java-retail#526)) ([eeb68fa](googleapis/java-retail@eeb68fa))
* **samples:** Removed region tags ([#531](googleapis/java-retail#531)) ([b12a8fe](googleapis/java-retail@b12a8fe))


### Documentation

* Improved documentation for Fullfillment and Inventory API in ProductService ([32a384d](googleapis/java-retail@32a384d))
* minor documentation format and typo fixes ([32a384d](googleapis/java-retail@32a384d))
* **samples:** Refactoring events package ([#481](googleapis/java-retail#481)) ([c644df0](googleapis/java-retail@c644df0))
* **samples:** Refactoring product package ([#480](googleapis/java-retail#480)) ([aebf241](googleapis/java-retail@aebf241))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#503](googleapis/java-retail#503)) ([58a7105](googleapis/java-retail@58a7105))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#519](googleapis/java-retail#519)) ([dc52906](googleapis/java-retail@dc52906))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#523](googleapis/java-retail#523)) ([3ad9ecf](googleapis/java-retail@3ad9ecf))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#524](googleapis/java-retail#524)) ([2b6c293](googleapis/java-retail@2b6c293))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#535](googleapis/java-retail#535)) ([826cbd6](googleapis/java-retail@826cbd6))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#533](googleapis/java-retail#533)) ([29807c8](googleapis/java-retail@29807c8))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#538](googleapis/java-retail#538)) ([e4170e8](googleapis/java-retail@e4170e8))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#511](googleapis/java-retail#511)) ([2c435e5](googleapis/java-retail@2c435e5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@chenlei1216 chenlei1216 chenlei1216 approved these changes

Assignees

@alicejli alicejli

Labels
api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dfirova @chenlei1216 @Neenu1995 @yoshi-kokoro @alicejli