test: Fix flaky tests #2221
Merged
test: Fix flaky tests #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
michaelpri10
changed the title
product-auto-label
bot
added
size: s
michaelpri10
changed the title
hongalex
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a flaky test for the EOD subscription sample. Currently, the test creates and deletes subscriptions before and after every test, but I believe this is causing flaky results. This only runs setUp and tearDown before and after the whole test suite.
This also fixes the GCS ingestion topic, by ensuring the minimum object create time is properly found in the topic definition.
Lastly, this fixes a flaky OpenTelemetry test by ensuring that the publisher is shutdown and all spans are ended.