feat: Adding grpc compression support #1000

rajanya-google · 2022-02-08T17:13:08Z

Adding gRPC compression support.

snippet-bot · 2022-02-09T22:01:18Z

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

beltran

If this PR was submitted, would the feature work, or are changes required in the server? If this is the case we probably would want to hold it off.

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/it/ITPubSubTest.java

samples/snippets/src/main/java/pubsub/PublishWithCompressionExample.java

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

samples/snippets/src/main/java/pubsub/PublishWithCompressionExample.java

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

samples/snippets/src/main/java/pubsub/PublishWithCompressionExample.java

anguillanneuf

@rajanya-google Please don't add samples in the same PR.

I need to work with you to plan the samples in the internal tools. This feature also needs to be released first before the sample tests will pass. When writing samples, please open a branch from this repo instead of a fork.

I also suggest we provide a short code snippet in the docstring as part of the library documentation.

rajanya-google · 2022-03-21T20:20:57Z

@rajanya-google Please don't add samples in the same PR.

I have removed sample for compression.

I need to work with you to plan the samples in the internal tools. This feature also needs to be released first before the sample tests will pass. When writing samples, please open a branch from this repo instead of a fork.

Sure.

I also suggest we provide a short code snippet in the docstring as part of the library documentation.

I don't quite follow this. Could you please point me to the location?

Thank you for removing samples are removed from this PR.

anguillanneuf · 2022-03-24T17:51:32Z

I also suggest we provide a short code snippet in the docstring as part of the library documentation.

I don't quite follow this. Could you please point me to the location?

Here's an example: https://cloud.google.com/java/docs/reference/google-cloud-pubsub/latest/com.google.cloud.pubsub.v1.PublisherInterface#methods

)

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 444328399 Source-Link: googleapis/googleapis@c7ca416 Source-Link: googleapis/googleapis-gen@d617054 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDYxNzA1NDUzYTYyYjNlY2RhNzhhYTMwYzE5Mjg0MGViYzVhOGE5MCJ9 feat: AuditConfig for IAM v1 PiperOrigin-RevId: 439356405 Source-Link: googleapis/googleapis@afa2ba1 Source-Link: googleapis/googleapis-gen@3e40c17 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2U0MGMxN2UxNTEwYzk1ZmFiNThmYzIxNDNjY2I2MWNjZWNhNTk4OSJ9

…a to 2.16.0 (googleapis#1107) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 446250659 Source-Link: googleapis/googleapis@dc4ef31 Source-Link: googleapis/googleapis-gen@5fdda4d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWZkZGE0ZGRmYmFiODc5OThlNzdlNGE0NTNlMGZmODc5ODZkMmRiOCJ9

…-info-reports-plugin to v3.3.0 (googleapis#1104) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-project-info-reports-plugin)) | `3.2.2` -> `3.3.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.3.0/compatibility-slim/3.2.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.3.0/confidence-slim/3.2.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).

mmicatka

LGTM

anguillanneuf · 2022-05-12T23:41:00Z

google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/it/ITPubSubTest.java

+    MessageAndConsumer toAck2 = pollQueueMessageAndConsumer(receiveQueue);
+    toAck2.consumer().ack();
+
+    assertNotEquals(toAck1.message().getData(), toAck2.message().getData());


@rajanya-google Can you help me understand the purpose of this test? I see two messages of different sizes getting published using a publisher with no batching configured, so each message is essentially published in its own batch of batch size 1, each message has a size greater than the compression threshold of 10 bytes, they will get compressed, then we read these messages and confirm that their data fields aren't equal (what's the point of that)?

rajanya-google requested a review from a team as a code owner February 8, 2022 17:13

product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Feb 8, 2022

rajanya-google requested review from pradn and removed request for pradn February 9, 2022 16:51

rajanya-google requested a review from a team as a code owner February 9, 2022 22:01

rajanya-google changed the title ~~feat: Adding grpc compression~~ feat: Adding grpc compression support Feb 9, 2022

rajanya-google force-pushed the grpc-compression branch from b59e331 to de51b2d Compare February 16, 2022 18:12

beltran reviewed Feb 23, 2022

View reviewed changes

rajanya-google requested a review from mmicatka March 2, 2022 17:29

mmicatka reviewed Mar 2, 2022

View reviewed changes

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated Show resolved Hide resolved

mmicatka reviewed Mar 2, 2022

View reviewed changes

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Show resolved Hide resolved

rajanya-google requested a review from hannahrogers-google March 2, 2022 19:59

rajanya-google requested a review from kamalaboulhosn March 10, 2022 17:35

mmicatka reviewed Mar 10, 2022

View reviewed changes

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Show resolved Hide resolved

kamalaboulhosn requested changes Mar 10, 2022

View reviewed changes

rajanya-google requested review from mmicatka and kamalaboulhosn March 11, 2022 21:58

anguillanneuf self-requested a review March 15, 2022 18:07

anguillanneuf previously requested changes Mar 15, 2022

View reviewed changes

anguillanneuf self-requested a review March 24, 2022 17:49

anguillanneuf closed this Mar 24, 2022

anguillanneuf reopened this Mar 24, 2022

rajanya-google added 4 commits April 11, 2022 11:16

Adding gRPC compression support to the library

47e4d21

Minor comment fix

7190fca

Formatting the code

8d05ba2

Adding unit test for compression

13a071d

rajanya-google and others added 8 commits May 6, 2022 15:49

Addressed PR comments

4d44679

Removing test

b1a2d37

fix: added exactly once delivery files to owlbot config (googleapis#1106

d913048

)

Formatting

1fb553c

product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 9, 2022

Formatting

f83bcc7

rajanya-google changed the base branch from main to hannahrogers-google-patch-2 May 9, 2022 15:04

rajanya-google changed the base branch from hannahrogers-google-patch-2 to main May 9, 2022 15:04

rajanya-google changed the base branch from main to 1.111.0-sp May 9, 2022 15:06

rajanya-google changed the base branch from 1.111.0-sp to main May 9, 2022 15:06

rajanya-google changed the base branch from main to 1.114.x May 9, 2022 15:10

rajanya-google changed the base branch from 1.114.x to main May 9, 2022 15:10

rajanya-google added the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2022

Merge remote-tracking branch 'upstream/main' into grpc-compression

3903653

product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 9, 2022

rajanya-google added the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2022

kamalaboulhosn approved these changes May 10, 2022

View reviewed changes

mmicatka approved these changes May 10, 2022

View reviewed changes

anguillanneuf merged commit 4ad1a3f into googleapis:main May 10, 2022

release-please bot mentioned this pull request May 10, 2022

chore(main): release 1.117.0 #1095

Merged

anguillanneuf reviewed May 12, 2022

View reviewed changes

hongalex mentioned this pull request Apr 4, 2024

feat(pubsub): support publisher compression googleapis/google-cloud-go#9711

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Adding grpc compression support #1000

feat: Adding grpc compression support #1000

rajanya-google commented Feb 8, 2022 •

edited

Loading

snippet-bot bot commented Feb 9, 2022 •

edited

Loading

beltran left a comment

anguillanneuf left a comment •

edited

Loading

rajanya-google commented Mar 21, 2022 •

edited

Loading

anguillanneuf commented Mar 24, 2022 •

edited

Loading

mmicatka left a comment

anguillanneuf May 12, 2022 •

edited

Loading

feat: Adding grpc compression support #1000

feat: Adding grpc compression support #1000

Conversation

rajanya-google commented Feb 8, 2022 • edited Loading

snippet-bot bot commented Feb 9, 2022 • edited Loading

No region tags are edited in this PR.

beltran left a comment

Choose a reason for hiding this comment

anguillanneuf left a comment • edited Loading

Choose a reason for hiding this comment

rajanya-google commented Mar 21, 2022 • edited Loading

anguillanneuf commented Mar 24, 2022 • edited Loading

mmicatka left a comment

Choose a reason for hiding this comment

anguillanneuf May 12, 2022 • edited Loading

Choose a reason for hiding this comment

rajanya-google commented Feb 8, 2022 •

edited

Loading

snippet-bot bot commented Feb 9, 2022 •

edited

Loading

anguillanneuf left a comment •

edited

Loading

rajanya-google commented Mar 21, 2022 •

edited

Loading

anguillanneuf commented Mar 24, 2022 •

edited

Loading

anguillanneuf May 12, 2022 •

edited

Loading