Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

docs: update classification sample to use v2 model #899

Merged
merged 1 commit into from
Sep 27, 2022
Merged

docs: update classification sample to use v2 model #899

merged 1 commit into from
Sep 27, 2022

Conversation

wizeng23
Copy link
Contributor

Fixes #898

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: language Issues related to the googleapis/java-language API. samples Issues that are directly related to samples. labels Sep 23, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@wizeng23
Copy link
Contributor Author

wizeng23 commented Sep 23, 2022 •
edited
Loading

Hi Neenu, the new imports I use were all added in the previous commit, ex: https://github.com/googleapis/java-language/blob/main/proto-google-cloud-language-v1/src/main/java/com/google/cloud/language/v1/ClassificationModelOptions.java. Is the Kokoro test failing because that commit has not made it into a release yet? If so, when will the next release be? If possible, it'd be nice to have this PR merged in by Tuesday.

@Neenu1995
Copy link
Contributor

Hi @wizeng23 ,
Yes, looks like the kokoro check is failing because the feature has not been released yet.
Triggering a release now. Once the samples pom is updated with the new version and the kokoro check passes with the new version, this PR can be merged.

@blakeli0 blakeli0 merged commit 7b3a5f8 into googleapis:main Sep 27, 2022
@release-please release-please bot mentioned this pull request Sep 27, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 5, 2022
@release-please
chore(main): release 2.4.1 (#904)
9ad17f6 
🤖 I have created a release *beep* *boop*
---


## [2.4.1](https://togithub.com/googleapis/java-language/compare/v2.4.0...v2.4.1) (2022-10-03)


### Documentation

* Update classification sample to use v2 model ([#899](https://togithub.com/googleapis/java-language/issues/899)) ([7b3a5f8](https://togithub.com/googleapis/java-language/commit/7b3a5f86b7de401198e74e76ba7af1f1599ae6cc))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#929](https://togithub.com/googleapis/java-language/issues/929)) ([805563b](https://togithub.com/googleapis/java-language/commit/805563b083bb04bfa59ef7fc4418c6950b3340db))
* Update dependency google-api-core to v2.10.1 ([#921](https://togithub.com/googleapis/java-language/issues/921)) ([8b39a51](https://togithub.com/googleapis/java-language/commit/8b39a51acbc452afc2bb045f6d88bbdfc46b81ed))
* Update dependency google-auth to v2.12.0 ([#922](https://togithub.com/googleapis/java-language/issues/922)) ([f273003](https://togithub.com/googleapis/java-language/commit/f273003a294fb2d116c78f25848bd22fa8f18fc8))
* Update dependency google-cloud-storage to v2.5.0 ([#923](https://togithub.com/googleapis/java-language/issues/923)) ([c34885b](https://togithub.com/googleapis/java-language/commit/c34885ba6ad41c8eeeeda2ad9feb20f89f67e589))
* Update dependency google-crc32c to v1.5.0 ([#924](https://togithub.com/googleapis/java-language/issues/924)) ([51baceb](https://togithub.com/googleapis/java-language/commit/51baceb6bf821f3da41569b27cd7cdf745bd1db8))
* Update dependency importlib-metadata to v4.12.0 ([#925](https://togithub.com/googleapis/java-language/issues/925)) ([a246f0d](https://togithub.com/googleapis/java-language/commit/a246f0dcc43ce8faeefdf998011222df294d27fa))
* Update dependency jeepney to v0.8.0 ([#926](https://togithub.com/googleapis/java-language/issues/926)) ([04a307a](https://togithub.com/googleapis/java-language/commit/04a307ad130c3adfb2471aac551ebfc674c0d060))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

@Neenu1995 Neenu1995

Labels
api: language Issues related to the googleapis/java-language API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update classification sample to use v2 model
4 participants
@wizeng23 @Neenu1995 @blakeli0 @yoshi-kokoro