Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Increase timeout for RecursiveDeleteTests #1498

Merged
merged 8 commits into from
Dec 8, 2023
Merged

test: Increase timeout for RecursiveDeleteTests #1498

merged 8 commits into from
Dec 8, 2023

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Dec 6, 2023

See this for more context

@ehsannas ehsannas requested a review from a team as a code owner December 6, 2023 23:33
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Dec 6, 2023
@ehsannas ehsannas changed the title Increase timeout for RecursiveDeleteTests. test: Increase timeout for RecursiveDeleteTests. Dec 6, 2023
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@ehsannas ehsannas force-pushed the ehsann/increase-timeout-recursive-delete-tests branch from 374095b to 1e771af Compare December 6, 2023 23:34
@ehsannas ehsannas requested a review from a team as a code owner December 6, 2023 23:35
@ehsannas ehsannas self-assigned this Dec 6, 2023
@ehsannas ehsannas requested a review from tom-andersen December 6, 2023 23:39
@ehsannas ehsannas assigned tom-andersen and unassigned ehsannas Dec 6, 2023
@ehsannas ehsannas mentioned this pull request Dec 6, 2023
Closed
@ehsannas
Copy link
Contributor Author

ehsannas commented Dec 7, 2023

Also increasing the timeout for the bulkwriter tests. It looks like 2 seconds is not enough sometimes.
See: https://github.com/googleapis/java-firestore/actions/runs/7122590138/job/19393867730?pr=1499#step:5:1857

@ehsannas ehsannas changed the title test: Increase timeout for RecursiveDeleteTests. test: Increase timeout for RecursiveDeleteTests and BulkWriterTests Dec 7, 2023
@ehsannas
Copy link
Contributor Author

ehsannas commented Dec 7, 2023 •
edited
Loading

Looks like the BulkWriter issue is not a matter of increasing timeout. See failure after a 10 second timeout:
https://github.com/googleapis/java-firestore/actions/runs/7122629244/job/19393969033?pr=1498#step:5:1424

Going to revert the timeout for bulkwriter tests back to the original value now.

@ehsannas ehsannas changed the title test: Increase timeout for RecursiveDeleteTests and BulkWriterTests test: Increase timeout for RecursiveDeleteTests Dec 7, 2023
tom-andersen
tom-andersen approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-andersen tom-andersen assigned ehsannas and unassigned tom-andersen Dec 7, 2023
@ehsannas ehsannas merged commit dfbcd9d into main Dec 8, 2023
22 of 23 checks passed
@ehsannas ehsannas deleted the ehsann/increase-timeout-recursive-delete-tests branch December 8, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsannas @tom-andersen