-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: Add sample snippets for IN, NOT_EQUALS, and NOT_IN #749
Conversation
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
72635ad
to
eef1851
Compare
Now that #688 is merged, this is also ready for review/merge. |
The project used for testing requires the index below for one of the snippets:
Can someone help me add this index to the testing project? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question. Thanks!
samples/snippets/src/test/java/com/google/datastore/snippets/ConceptsTest.java
Outdated
Show resolved
Hide resolved
Looks like ConceptsTest.java runs against the Datastore emulator. The new query operators will not be supported by the emulator any time soon. Not sure how to proceed. Is there a way to run the new tests against a real backend? |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Can someone re-trigger the workflows for me again? |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #738 ☕️
Depends on #688
If you write sample code, please follow the samples format.