Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose Datastore Admin generated client #748

Merged
merged 5 commits into from
May 31, 2022
Merged

feat: Expose Datastore Admin generated client #748

merged 5 commits into from
May 31, 2022

Conversation

pcostell
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: datastore Issues related to the googleapis/java-datastore API. labels May 25, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Key.java
  • proto-google-cloud-datastore-v1/src/main/proto/google/datastore/v1/entity.proto

@pcostell pcostell force-pushed the owl branch 5 times, most recently from 75816ce to 384c707 Compare May 25, 2022 18:40
@pcostell pcostell marked this pull request as ready for review May 25, 2022 20:09
@pcostell pcostell requested review from a team as code owners May 25, 2022 20:09
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@pcostell pcostell added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@pcostell pcostell force-pushed the owl branch 2 times, most recently from d71f4dc to e5b016e Compare May 27, 2022 04:07
@product-auto-label product-auto-label bot added size: s Pull request size is small. size: xl Pull request size is extra large. and removed size: xl Pull request size is extra large. size: s Pull request size is small. labels May 27, 2022
@pcostell pcostell changed the title feat: Expose gapic & grpc clients for Datastore V1. feat: Expose Datastore Admin client May 27, 2022
@pcostell pcostell added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@pcostell pcostell force-pushed the owl branch 2 times, most recently from 26638cc to 14e7b8a Compare May 27, 2022 16:35
@pcostell pcostell force-pushed the owl branch 3 times, most recently from a81ab5a to 32b1d7a Compare May 27, 2022 19:11
@pcostell pcostell added the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
pcostell added 2 commits May 27, 2022 14:16
@pcostell
feat: Publish gapic admin client.
9a81c18
@pcostell
chore: Run owl manually.
6ffb2dd 
Correct missing dependencies not generated by owl.
@pcostell pcostell added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@pcostell
Copy link
Contributor Author

I think actually ready for review now @kolea2, thanks for your help!

@kolea2 kolea2 changed the title feat: Expose Datastore Admin client feat: Expose Datastore Admin generated client May 31, 2022
kolea2
kolea2 reviewed May 31, 2022
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, one comment/question. Thanks!

pom.xml Outdated Show resolved Hide resolved
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2022
@kolea2 kolea2 merged commit 3dd882a into googleapis:main May 31, 2022
This was referenced May 31, 2022
Closed
Merged
@kolea2 kolea2 mentioned this pull request May 31, 2022
Closed
gcf-merge-on-green bot pushed a commit that referenced this pull request May 31, 2022
@release-please
chore(main): release 2.6.0 (#756)
6e6cd3f 
🤖 I have created a release *beep* *boop*
---


## [2.6.0](v2.5.1...v2.6.0) (2022-05-31)


### Features

* Expose Datastore Admin generated client ([#748](#748)) ([3dd882a](3dd882a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@fkorotkov
Copy link

Can we do the same for the regular Datastore client? There is no grpc-google-cloud-datastore-v1 unfortunetly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcostell @fkorotkov @kolea2 @yoshi-kokoro