-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sum and Avg aggregation feature #1067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
Pull request size is large.
api: datastore
Issues related to the googleapis/java-datastore API.
labels
May 8, 2023
kolea2
suggested changes
May 12, 2023
google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationQuery.java
Show resolved
Hide resolved
google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationResult.java
Show resolved
Hide resolved
google-cloud-datastore/src/main/java/com/google/cloud/datastore/aggregation/AvgAggregation.java
Show resolved
Hide resolved
google-cloud-datastore/src/main/java/com/google/cloud/datastore/aggregation/AvgAggregation.java
Show resolved
Hide resolved
google-cloud-datastore/src/main/java/com/google/cloud/datastore/aggregation/AvgAggregation.java
Outdated
Show resolved
Hide resolved
google-cloud-datastore/src/test/java/com/google/cloud/datastore/AggregationQueryTest.java
Outdated
Show resolved
Hide resolved
...cloud-datastore/src/test/java/com/google/cloud/datastore/aggregation/AvgAggregationTest.java
Show resolved
Hide resolved
...cloud-datastore/src/test/java/com/google/cloud/datastore/aggregation/SumAggregationTest.java
Show resolved
Hide resolved
...a/com/google/cloud/datastore/execution/response/AggregationQueryResponseTransformerTest.java
Outdated
Show resolved
Hide resolved
...cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreAggregationsTest.java
Show resolved
Hide resolved
kolea2
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
May 12, 2023
product-auto-label
bot
added
size: xl
Pull request size is extra large.
and removed
size: l
Pull request size is large.
labels
May 15, 2023
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: xl
Pull request size is extra large.
labels
May 18, 2023
kolea2
reviewed
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking really good!
google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationQuery.java
Show resolved
Hide resolved
jainsahab
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Aug 17, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Aug 17, 2023
kolea2
reviewed
Aug 17, 2023
...cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreAggregationsTest.java
Show resolved
Hide resolved
kolea2
reviewed
Aug 17, 2023
google-cloud-datastore/src/main/java/com/google/cloud/datastore/aggregation/Aggregation.java
Outdated
Show resolved
Hide resolved
product-auto-label
bot
added
size: xl
Pull request size is extra large.
and removed
size: l
Pull request size is large.
labels
Aug 18, 2023
kolea2
approved these changes
Aug 18, 2023
meredithslota
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Aug 18, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Aug 18, 2023
meltsufin
reviewed
Aug 18, 2023
google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationResult.java
Outdated
Show resolved
Hide resolved
google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationResult.java
Outdated
Show resolved
Hide resolved
google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationResult.java
Outdated
Show resolved
Hide resolved
meltsufin
approved these changes
Aug 21, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Aug 21, 2023
kolea2
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: datastore
Issues related to the googleapis/java-datastore API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for querying the mathematical SUM and AVERAGE of an entity's specific field chosen by user.