Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support IN/NOT_IN/NOT_EQUAL operators #688

Merged
merged 3 commits into from
Jun 9, 2022
Merged

feat: support IN/NOT_IN/NOT_EQUAL operators #688

merged 3 commits into from
Jun 9, 2022

Conversation

Vincent-Weng
Copy link
Contributor

Adds implementation to support IN/NOT_IN/NOT_EQUAL operators for datastore Java SDK

Fixes #665 ☕️

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Mar 17, 2022
@kolea2 kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 18, 2022
@Vincent-Weng Vincent-Weng force-pushed the implement-in-notin-neq branch 2 times, most recently from 0a213b4 to 043d5e2 Compare March 18, 2022 21:36
@jlara310 jlara310 mentioned this pull request May 19, 2022
Closed
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2022
@jlara310 jlara310 mentioned this pull request May 25, 2022
Merged
4 tasks
@Vincent-Weng Vincent-Weng force-pushed the implement-in-notin-neq branch from 043d5e2 to 81c7893 Compare May 25, 2022 15:49
@Vincent-Weng Vincent-Weng requested review from a team as code owners May 25, 2022 15:49
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 25, 2022
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2022
@kolea2 kolea2 added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2022
@kolea2 kolea2 changed the title [DO NOT MERGE] feat: support IN/NOT_IN/NOT_EQUAL operators feat: support IN/NOT_IN/NOT_EQUAL operators May 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2022
@Vincent-Weng Vincent-Weng requested a review from a team as a code owner May 25, 2022 17:49
@Vincent-Weng Vincent-Weng force-pushed the implement-in-notin-neq branch from 6c5e97a to 561f061 Compare May 26, 2022 02:45
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@Vincent-Weng Vincent-Weng force-pushed the implement-in-notin-neq branch from 561f061 to 3812e5b Compare May 26, 2022 16:52
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
kolea2
kolea2 previously approved these changes May 26, 2022
View reviewed changes
@kolea2 kolea2 added automerge Merge the pull request once unit tests and other checks pass. do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed automerge Merge the pull request once unit tests and other checks pass. labels May 26, 2022
@kolea2 kolea2 dismissed their stale review May 26, 2022 17:59

not ready for merge

@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 7, 2022
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2022
@kolea2 kolea2 merged commit f8a84ff into googleapis:main Jun 9, 2022
@release-please release-please bot mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support IN/NOT_IN/NOT_EQUAL operators
3 participants
@Vincent-Weng @kolea2 @yoshi-kokoro