fix: close JarFiles opened by ConformanceTestLocator (#662)

googleapis · Oct 8, 2024 · 3b7da93 · 3b7da93
1 parent 82a5acf
commit 3b7da93
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/main/java/com/google/cloud/conformance/ConformanceTestLocator.java b/src/main/java/com/google/cloud/conformance/ConformanceTestLocator.java
@@ -131,12 +131,13 @@ private static List<String> handleJarScheme(final URL url, MatchPattern mp) thro
     final String jarPath = urlPath.substring(5, urlPath.indexOf("!"));
 
     final List<String> resourcePaths = new ArrayList<>();
-    final JarFile jarFile = new JarFile(jarPath);
-    final Enumeration<JarEntry> jarEntries = jarFile.entries();
-    while (jarEntries.hasMoreElements()) {
-      JarEntry je = jarEntries.nextElement();
-      if (!je.isDirectory() && mp.matches(je.getName())) {
-        resourcePaths.add(je.getName());
+    try (final JarFile jarFile = new JarFile(jarPath)) {
+      final Enumeration<JarEntry> jarEntries = jarFile.entries();
+      while (jarEntries.hasMoreElements()) {
+        JarEntry je = jarEntries.nextElement();
+        if (!je.isDirectory() && mp.matches(je.getName())) {
+          resourcePaths.add(je.getName());
+        }
       }
     }
     return resourcePaths;