fix!: change pagination return type for listManagedInstances

README.md

@@ -20,18 +20,19 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file
     <dependency>
       <groupId>com.google.cloud</groupId>
       <artifactId>libraries-bom</artifactId>
-      <version>4.3.0</version>
+      <version>4.4.1</version>
       <type>pom</type>
       <scope>import</scope>
     </dependency>
   </dependencies>
 </dependencyManagement>
+
 <dependencies>
   <dependency>
     <groupId>com.google.cloud</groupId>
     <artifactId>google-cloud-compute</artifactId>
   </dependency>
-</dependencies>
+
 ```
 
 [//]: # ({x-version-update-start:google-cloud-compute:released})
@@ -44,6 +45,7 @@ If you are using Maven without BOM, add this to your dependencies:
   <artifactId>google-cloud-compute</artifactId>
   <version>0.117.0-alpha</version>
 </dependency>
+
 ```
 
 If you are using Gradle, add this to your dependencies

clirr-ignored-differences.xml

@@ -37,4 +37,22 @@
     <className>com/google/cloud/compute/v1/*Client</className>
     <method>* aggregatedList*</method>
   </difference>
+  <difference>
+    <differenceType>7006</differenceType>
+    <className>com/google/cloud/compute/v1/*InstanceGroupManagerClient</className>
+    <method>com.google.cloud.compute.v1.*InstanceGroupManagersList*InstancesResponse listManagedInstances*InstanceGroupManagers(*)</method>
+    <to>com.google.cloud.compute.v1.*InstanceGroupManagerClient$ListManagedInstances*InstanceGroupManagersPagedResponse</to>
+  </difference>
+  <difference>
+    <differenceType>7006</differenceType>
+    <className>com/google/cloud/compute/v1/*InstanceGroupManagerSettings*</className>
+    <method>com.google.api.gax.rpc.UnaryCallSettings* listManagedInstances*InstanceGroupManagersSettings()</method>
+    <to>com.google.api.gax.rpc.PagedCallSettings*</to>
+  </difference>
+  <difference>
+    <differenceType>7006</differenceType>
+    <className>com/google/cloud/compute/v1/stub/*InstanceGroupManagerStubSettings*</className>
+    <method>com.google.api.gax.rpc.UnaryCallSettings* listManagedInstances*InstanceGroupManagersSettings()</method>
+    <to>com.google.api.gax.rpc.PagedCallSettings*</to>
+  </difference>
 </differences>

src/main/java/com/google/cloud/compute/v1/AggregatedListAcceleratorTypesHttpRequest.java

@@ -168,21 +168,21 @@ public String getFields() {
   /**
    * A filter expression that filters resources listed in the response. The expression must specify
    * the field name, a comparison operator, and the value that you want to use for filtering. The
-   * value must be a string, a number, or a boolean. The comparison operator must be either =, !=,
-   * >, or <.
+   * value must be a string, a number, or a boolean. The comparison operator must be either `=`,
+   * `!=`, `>`, or `<`.
    *
    * <p>For example, if you are filtering Compute Engine instances, you can exclude instances named
-   * example-instance by specifying name != example-instance.
+   * `example-instance` by specifying `name != example-instance`.
    *
    * <p>You can also filter nested fields. For example, you could specify
-   * scheduling.automaticRestart = false to include instances only if they are not scheduled for
+   * `scheduling.automaticRestart = false` to include instances only if they are not scheduled for
    * automatic restarts. You can use filtering on nested fields to filter based on resource labels.
    *
    * <p>To filter on multiple expressions, provide each separate expression within parentheses. For
-   * example, (scheduling.automaticRestart = true) (cpuPlatform = "Intel Skylake"). By default, each
-   * expression is an AND expression. However, you can include AND and OR expressions explicitly.
-   * For example, (cpuPlatform = "Intel Skylake") OR (cpuPlatform = "Intel Broadwell") AND
-   * (scheduling.automaticRestart = true).
+   * example: ``` (scheduling.automaticRestart = true) (cpuPlatform = "Intel Skylake") ``` By
+   * default, each expression is an `AND` expression. However, you can include `AND` and `OR`
+   * expressions explicitly. For example: ``` (cpuPlatform = "Intel Skylake") OR (cpuPlatform =
+   * "Intel Broadwell") AND (scheduling.automaticRestart = true) ```
    */
   public String getFilter() {
     return filter;
@@ -206,9 +206,9 @@ public String getKey() {
 
   /**
    * The maximum number of results per page that should be returned. If the number of available
-   * results is larger than maxResults, Compute Engine returns a nextPageToken that can be used to
-   * get the next page of results in subsequent list requests. Acceptable values are 0 to 500,
-   * inclusive. (Default: 500)
+   * results is larger than `maxResults`, Compute Engine returns a `nextPageToken` that can be used
+   * to get the next page of results in subsequent list requests. Acceptable values are `0` to
+   * `500`, inclusive. (Default: `500`)
    */
   public Integer getMaxResults() {
     return maxResults;
@@ -219,19 +219,19 @@ public Integer getMaxResults() {
    * based on the resource name.
    *
    * <p>You can also sort results in descending order based on the creation timestamp using
-   * orderBy="creationTimestamp desc". This sorts results based on the creationTimestamp field in
-   * reverse chronological order (newest result first). Use this to sort resources like operations
-   * so that the newest operation is returned first.
+   * `orderBy="creationTimestamp desc"`. This sorts results based on the `creationTimestamp` field
+   * in reverse chronological order (newest result first). Use this to sort resources like
+   * operations so that the newest operation is returned first.
    *
-   * <p>Currently, only sorting by name or creationTimestamp desc is supported.
+   * <p>Currently, only sorting by `name` or `creationTimestamp desc` is supported.
    */
   public String getOrderBy() {
     return orderBy;
   }
 
   /**
-   * Specifies a page token to use. Set pageToken to the nextPageToken returned by a previous list
-   * request to get the next page of results.
+   * Specifies a page token to use. Set `pageToken` to the `nextPageToken` returned by a previous
+   * list request to get the next page of results.
    */
   public String getPageToken() {
     return pageToken;
@@ -399,21 +399,21 @@ public Builder setFields(String fields) {
      * A filter expression that filters resources listed in the response. The expression must
      * specify the field name, a comparison operator, and the value that you want to use for
      * filtering. The value must be a string, a number, or a boolean. The comparison operator must
-     * be either =, !=, &gt;, or &lt;.
+     * be either `=`, `!=`, `&gt;`, or `&lt;`.
      *
      * <p>For example, if you are filtering Compute Engine instances, you can exclude instances
-     * named example-instance by specifying name != example-instance.
+     * named `example-instance` by specifying `name != example-instance`.
      *
      * <p>You can also filter nested fields. For example, you could specify
-     * scheduling.automaticRestart = false to include instances only if they are not scheduled for
+     * `scheduling.automaticRestart = false` to include instances only if they are not scheduled for
      * automatic restarts. You can use filtering on nested fields to filter based on resource
      * labels.
      *
      * <p>To filter on multiple expressions, provide each separate expression within parentheses.
-     * For example, (scheduling.automaticRestart = true) (cpuPlatform = "Intel Skylake"). By
-     * default, each expression is an AND expression. However, you can include AND and OR
-     * expressions explicitly. For example, (cpuPlatform = "Intel Skylake") OR (cpuPlatform = "Intel
-     * Broadwell") AND (scheduling.automaticRestart = true).
+     * For example: ``` (scheduling.automaticRestart = true) (cpuPlatform = "Intel Skylake") ``` By
+     * default, each expression is an `AND` expression. However, you can include `AND` and `OR`
+     * expressions explicitly. For example: ``` (cpuPlatform = "Intel Skylake") OR (cpuPlatform =
+     * "Intel Broadwell") AND (scheduling.automaticRestart = true) ```
      */
     public String getFilter() {
       return filter;
@@ -423,21 +423,21 @@ public String getFilter() {
      * A filter expression that filters resources listed in the response. The expression must
      * specify the field name, a comparison operator, and the value that you want to use for
      * filtering. The value must be a string, a number, or a boolean. The comparison operator must
-     * be either =, !=, &gt;, or &lt;.
+     * be either `=`, `!=`, `&gt;`, or `&lt;`.
      *
      * <p>For example, if you are filtering Compute Engine instances, you can exclude instances
-     * named example-instance by specifying name != example-instance.
+     * named `example-instance` by specifying `name != example-instance`.
      *
      * <p>You can also filter nested fields. For example, you could specify
-     * scheduling.automaticRestart = false to include instances only if they are not scheduled for
+     * `scheduling.automaticRestart = false` to include instances only if they are not scheduled for
      * automatic restarts. You can use filtering on nested fields to filter based on resource
      * labels.
      *
      * <p>To filter on multiple expressions, provide each separate expression within parentheses.
-     * For example, (scheduling.automaticRestart = true) (cpuPlatform = "Intel Skylake"). By
-     * default, each expression is an AND expression. However, you can include AND and OR
-     * expressions explicitly. For example, (cpuPlatform = "Intel Skylake") OR (cpuPlatform = "Intel
-     * Broadwell") AND (scheduling.automaticRestart = true).
+     * For example: ``` (scheduling.automaticRestart = true) (cpuPlatform = "Intel Skylake") ``` By
+     * default, each expression is an `AND` expression. However, you can include `AND` and `OR`
+     * expressions explicitly. For example: ``` (cpuPlatform = "Intel Skylake") OR (cpuPlatform =
+     * "Intel Broadwell") AND (scheduling.automaticRestart = true) ```
      */
     public Builder setFilter(String filter) {
       this.filter = filter;
@@ -480,19 +480,19 @@ public Builder setKey(String key) {
 
     /**
      * The maximum number of results per page that should be returned. If the number of available
-     * results is larger than maxResults, Compute Engine returns a nextPageToken that can be used to
-     * get the next page of results in subsequent list requests. Acceptable values are 0 to 500,
-     * inclusive. (Default: 500)
+     * results is larger than `maxResults`, Compute Engine returns a `nextPageToken` that can be
+     * used to get the next page of results in subsequent list requests. Acceptable values are `0`
+     * to `500`, inclusive. (Default: `500`)
      */
     public Integer getMaxResults() {
       return maxResults;
     }
 
     /**
      * The maximum number of results per page that should be returned. If the number of available
-     * results is larger than maxResults, Compute Engine returns a nextPageToken that can be used to
-     * get the next page of results in subsequent list requests. Acceptable values are 0 to 500,
-     * inclusive. (Default: 500)
+     * results is larger than `maxResults`, Compute Engine returns a `nextPageToken` that can be
+     * used to get the next page of results in subsequent list requests. Acceptable values are `0`
+     * to `500`, inclusive. (Default: `500`)
      */
     public Builder setMaxResults(Integer maxResults) {
       this.maxResults = maxResults;
@@ -504,11 +504,11 @@ public Builder setMaxResults(Integer maxResults) {
      * order based on the resource name.
      *
      * <p>You can also sort results in descending order based on the creation timestamp using
-     * orderBy="creationTimestamp desc". This sorts results based on the creationTimestamp field in
-     * reverse chronological order (newest result first). Use this to sort resources like operations
-     * so that the newest operation is returned first.
+     * `orderBy="creationTimestamp desc"`. This sorts results based on the `creationTimestamp` field
+     * in reverse chronological order (newest result first). Use this to sort resources like
+     * operations so that the newest operation is returned first.
      *
-     * <p>Currently, only sorting by name or creationTimestamp desc is supported.
+     * <p>Currently, only sorting by `name` or `creationTimestamp desc` is supported.
      */
     public String getOrderBy() {
       return orderBy;
@@ -519,28 +519,28 @@ public String getOrderBy() {
      * order based on the resource name.
      *
      * <p>You can also sort results in descending order based on the creation timestamp using
-     * orderBy="creationTimestamp desc". This sorts results based on the creationTimestamp field in
-     * reverse chronological order (newest result first). Use this to sort resources like operations
-     * so that the newest operation is returned first.
+     * `orderBy="creationTimestamp desc"`. This sorts results based on the `creationTimestamp` field
+     * in reverse chronological order (newest result first). Use this to sort resources like
+     * operations so that the newest operation is returned first.
      *
-     * <p>Currently, only sorting by name or creationTimestamp desc is supported.
+     * <p>Currently, only sorting by `name` or `creationTimestamp desc` is supported.
      */
     public Builder setOrderBy(String orderBy) {
       this.orderBy = orderBy;
       return this;
     }
 
     /**
-     * Specifies a page token to use. Set pageToken to the nextPageToken returned by a previous list
-     * request to get the next page of results.
+     * Specifies a page token to use. Set `pageToken` to the `nextPageToken` returned by a previous
+     * list request to get the next page of results.
      */
     public String getPageToken() {
       return pageToken;
     }
 
     /**
-     * Specifies a page token to use. Set pageToken to the nextPageToken returned by a previous list
-     * request to get the next page of results.
+     * Specifies a page token to use. Set `pageToken` to the `nextPageToken` returned by a previous
+     * list request to get the next page of results.
      */
     public Builder setPageToken(String pageToken) {
       this.pageToken = pageToken;