-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include User agent #404
Conversation
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
============================================
- Coverage 80.42% 80.42% -0.01%
Complexity 1113 1113
============================================
Files 105 105
Lines 6897 6902 +5
Branches 369 369
============================================
+ Hits 5547 5551 +4
- Misses 1150 1152 +2
+ Partials 200 199 -1
Continue to review full report at Codecov.
|
ebaa303
to
24db7f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is incompatible with the hbase client. I ran a snapshot locally and got this error in https://github.com/googleapis/java-bigtable-hbase/blob/master/bigtable-client-core-parent/bigtable-client-core/src/test/java/com/google/cloud/bigtable/grpc/TestHeaders.java#L103:
java.lang.IllegalArgumentException: Multiple entries with same key: user-agent=bigtable-java/1.14.1-SNAPSHOT and user-agent=bigtable-1.14.1-SNAPSHOT,jdk-11,veneer-adapter,test-user-agent
at com.google.common.collect.RegularImmutableMap.duplicateKeyException(RegularImmutableMap.java:181)
at com.google.common.collect.RegularImmutableMap.createHashTable(RegularImmutableMap.java:120)
at com.google.common.collect.RegularImmutableMap.create(RegularImmutableMap.java:81)
This should be addressed in parallel to this.
ok, lets leave this be and I'll address it in the next release |
…user headers This is primarily meant to address the googleapis/java-bigtable#404 (review). Where both the hbase adapter and the core client needs to set the UserAgent. To reconcile the conflict this PR takes grpc's approach and concatenates the values. The reason this needs to happen now is that for DirectPath we need to ship clients that send a UserAgent, however Bigtable needs to keep stats to differentiate client usage.
…user headers (#1190) * feat: Allow user-agents to be specified by both internal headers and user headers This is primarily meant to address the googleapis/java-bigtable#404 (review). Where both the hbase adapter and the core client needs to set the UserAgent. To reconcile the conflict this PR takes grpc's approach and concatenates the values. The reason this needs to happen now is that for DirectPath we need to ship clients that send a UserAgent, however Bigtable needs to keep stats to differentiate client usage. * remove stale code
I updated gax to workaround this issue. We just need a new release of gax (> 1.58.3) and then we should able to merge this |
@igorbernstein2 Seems gax-java has just released 1.59.0, which has your changes:) |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.api:gax-grpc](https://togithub.com/googleapis/gax-java) | minor | `1.58.2` -> `1.59.1` | | [com.google.api:gax-bom](https://togithub.com/googleapis/gax-java) | minor | `1.58.2` -> `1.59.1` | --- ### Release Notes <details> <summary>googleapis/gax-java</summary> ### [`v1.59.1`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1591-httpswwwgithubcomgoogleapisgax-javacomparev1590v1591-2020-10-05) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.59.0...v1.59.1) ### [`v1.59.0`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1590-httpswwwgithubcomgoogleapisgax-javacomparev1583v1590-2020-09-28) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.58.3...v1.59.0) ##### Features - Allow user-agents to be specified by both internal headers and user headers ([#​1190](https://www.github.com/googleapis/gax-java/issues/1190)) ([266329e](https://www.github.com/googleapis/gax-java/commit/266329e89642bfc6be579e600d3f995f4416ae4e)), closes [/github.com/googleapis/java-bigtable/pull/404#pullrequestreview-480972135](https://www.github.com/googleapis//github.com/googleapis/java-bigtable/pull/404/issues/pullrequestreview-480972135) ##### Bug Fixes - truncate RPC timeouts to time remaining in totalTimeout ([#​1191](https://www.github.com/googleapis/gax-java/issues/1191)) ([1d0c940](https://www.github.com/googleapis/gax-java/commit/1d0c94061bab124be81a649ac3fa1ce5d9a2df23)) ##### Dependencies - update guava to 29.0-android ([#​1174](https://www.github.com/googleapis/gax-java/issues/1174)) ([287cada](https://www.github.com/googleapis/gax-java/commit/287cadae528549545da9e7e9d63fd70c1268e3c1)), closes [#​1151](https://www.github.com/googleapis/gax-java/issues/1151) ##### [1.58.3](https://www.github.com/googleapis/gax-java/compare/v1.58.2...v1.58.3) (2020-09-15) ##### Bug Fixes - [gax-java] Add speedy Bazel builds to Travis ([#​1181](https://www.github.com/googleapis/gax-java/issues/1181)) ([2fb85fe](https://www.github.com/googleapis/gax-java/commit/2fb85fed095c6043ee39b63a0f7dff3fd93cbd7b)) - [gax-java] add Vim files to .gitignore ([#​1179](https://www.github.com/googleapis/gax-java/issues/1179)) ([2de22b6](https://www.github.com/googleapis/gax-java/commit/2de22b6645fbfd7ada7d0067e5cdd3c2039ec190)) - [gax-java] Fix broken Bazel build ([#​1180](https://www.github.com/googleapis/gax-java/issues/1180)) ([834c05e](https://www.github.com/googleapis/gax-java/commit/834c05e1d35a17f90bf8cd1b2cdce40bea451c95)) ##### [1.58.2](https://www.github.com/googleapis/gax-java/compare/v1.58.1...v1.58.2) (2020-08-07) ##### Bug Fixes - Settings objects should not try to read quotaProjectId from credentials ([#​1162](https://www.github.com/googleapis/gax-java/issues/1162)) ([1b09bcf](https://www.github.com/googleapis/gax-java/commit/1b09bcff1ddfaed8cfa58b92c787f8fc9b08abef)) ##### [1.58.1](https://www.github.com/googleapis/gax-java/compare/v1.58.0...v1.58.1) (2020-08-06) ##### Bug Fixes - fix dependencies.properties resource file creation during deployment ([#​1163](https://www.github.com/googleapis/gax-java/issues/1163)) ([3e7e1f1](https://www.github.com/googleapis/gax-java/commit/3e7e1f1e64bdeb23a51b5155faea975beec0bc84)) - Watchdog.shutdownNow() does not shutdown executor ([#​1158](https://www.github.com/googleapis/gax-java/issues/1158)) ([6241a21](https://www.github.com/googleapis/gax-java/commit/6241a2118690d07dd28ffb9447423363f3f914e4)) ### [`v1.58.3`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1583-httpswwwgithubcomgoogleapisgax-javacomparev1582v1583-2020-09-15) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.58.2...v1.58.3) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).
Waiting on googleapis/java-shared-dependencies#160 to be pushed to maven |
Will merge this after #442 |
9ebfd33
to
203ce29
Compare
Confirmed that after #442, this no longer breaks java-bigtable-hbase |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.16.0](https://www.github.com/googleapis/java-bigtable/compare/v1.15.0...v1.16.0) (2020-10-06) ### Features * add keepalive changes in java client library ([#409](https://www.github.com/googleapis/java-bigtable/issues/409)) ([edbcde1](https://www.github.com/googleapis/java-bigtable/commit/edbcde1a5b22317319803cb57401252aac6d580d)) * include User agent ([#404](https://www.github.com/googleapis/java-bigtable/issues/404)) ([0cd71b5](https://www.github.com/googleapis/java-bigtable/commit/0cd71b59305cd7a336c223faff68402a8bee4639)) * Ability to extend UserAgent string (via gax upgrade) ### Bug Fixes * **test:** Clean up tests ([#439](https://www.github.com/googleapis/java-bigtable/issues/439)) ([c5c881b](https://www.github.com/googleapis/java-bigtable/commit/c5c881bb956860a393c2a7f34d0d790a23d270af)) * Add documentation to bulkReadRows that each batch will process t… ([#410](https://www.github.com/googleapis/java-bigtable/issues/410)) ([71dc8e3](https://www.github.com/googleapis/java-bigtable/commit/71dc8e3419fbb49d48bb7a3fd984d24e24661c81)) * Filters should be serializable ([#397](https://www.github.com/googleapis/java-bigtable/issues/397)) ([57edfde](https://www.github.com/googleapis/java-bigtable/commit/57edfde5eace28d50ec777e14589c9747616f0a8)) * RowCells are not actually serializeable ([#407](https://www.github.com/googleapis/java-bigtable/issues/407)) ([39e17cc](https://www.github.com/googleapis/java-bigtable/commit/39e17cc17c438f2d665875f9ff2b2cdf984e37b7)) * Fix race condition in Batcher.close() (via gax upgrade) ### Dependencies * update dependency com.google.cloud:google-cloud-conformance-tests to v0.0.12 ([#415](https://www.github.com/googleapis/java-bigtable/issues/415)) ([7b3713a](https://www.github.com/googleapis/java-bigtable/commit/7b3713a8935b2f0b1ca57d189e9e0363506b28a1)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([#428](https://www.github.com/googleapis/java-bigtable/issues/428)) ([373032e](https://www.github.com/googleapis/java-bigtable/commit/373032e93b838cbc0ccab7dc45cd61b3b973542a)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.1 ([#443](https://www.github.com/googleapis/java-bigtable/issues/443)) ([939fefa](https://www.github.com/googleapis/java-bigtable/commit/939fefa819d09885489d9faeedadc74ee2b0e1b9)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.1 ([#427](https://www.github.com/googleapis/java-bigtable/issues/427)) ([5175e28](https://www.github.com/googleapis/java-bigtable/commit/5175e28f5ce69f6fb3ed14131c1cfd26dbc47bb9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | patch | `1.32.1` -> `1.32.2` | | [com.google.auth:google-auth-library-bom](https://togithub.com/googleapis/google-auth-library-java) | minor | `0.21.1` -> `0.22.0` | | [com.google.api:gax-bom](https://togithub.com/googleapis/gax-java) | minor | `1.58.2` -> `1.60.0` | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.32.2`](https://togithub.com/grpc/grpc-java/releases/v1.32.2) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.32.1...v1.32.2) ##### Bug Fixes - netty: TCP close during TLS handshake should be UNAVAILABLE, not UNKNOWN - netty: BDP ping accounting should occur after flow control. This resolves an incompatibility issue introduced in v1.30.0 and could be worked around via `GRPC_EXPERIMENTAL_AUTOFLOWCONTROL=false` introduced later. The symptom was a GOAWAY with “too_many_pings” without an aggressive keepalive configured. The environment variable is still available, but will be removed in the future - alts: Reverted workaround for Conscrypt cipher performance. Conscrypt 2.5.0 has significantly improved performance and the workaround now decreases performance. Note that grpc-alts itself still depends on Conscrypt 2.2.1 to remain stable for this bug fix release, but users are encouraged to use newer a version of Conscrypt. The gains from Conscrypt 2.5.0 are significantly greater than what the workaround provided </details> <details> <summary>googleapis/google-auth-library-java</summary> ### [`v0.22.0`](https://togithub.com/googleapis/google-auth-library-java/blob/master/CHANGELOG.md#​0220-httpswwwgithubcomgoogleapisgoogle-auth-library-javacomparev0211v0220-2020-10-13) [Compare Source](https://togithub.com/googleapis/google-auth-library-java/compare/v0.21.1...v0.22.0) ##### Features - add logging at FINE level for each step of ADC ([#​435](https://www.github.com/googleapis/google-auth-library-java/issues/435)) ([7d145b2](https://www.github.com/googleapis/google-auth-library-java/commit/7d145b2371033093ea13fd05520c90970a5ef363)) ##### Documentation - remove bad javadoc tags ([#​478](https://www.github.com/googleapis/google-auth-library-java/issues/478)) ([a329c41](https://www.github.com/googleapis/google-auth-library-java/commit/a329c4171735c3d4ee574978e6c3742b96c01f74)) ##### Dependencies - update dependency com.google.http-client:google-http-client-bom to v1.37.0 ([#​486](https://www.github.com/googleapis/google-auth-library-java/issues/486)) ([3027fbf](https://www.github.com/googleapis/google-auth-library-java/commit/3027fbfaf017f5aa5a22cc51cd38a522597729c0)) ##### [0.21.1](https://www.github.com/googleapis/google-auth-library-java/compare/v0.21.0...v0.21.1) (2020-07-07) ##### Dependencies - update google-http-client to 1.36.0 ([#​447](https://www.github.com/googleapis/google-auth-library-java/issues/447)) ([b913d19](https://www.github.com/googleapis/google-auth-library-java/commit/b913d194259e4f93bb401a844480f56b48dad3bd)), closes [#​446](https://www.github.com/googleapis/google-auth-library-java/issues/446) </details> <details> <summary>googleapis/gax-java</summary> ### [`v1.60.0`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1600-httpswwwgithubcomgoogleapisgax-javacomparev1591v1600-2020-10-19) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.59.1...v1.60.0) ##### Features - REST Gapic (REGAPIC) Support ([#​1177](https://www.github.com/googleapis/gax-java/issues/1177)) ([12b18ee](https://www.github.com/googleapis/gax-java/commit/12b18ee255d3fabe13bb3969df40753b29f830d5)) ##### Bug Fixes - prevent npe caused by missing parentheses ([#​1198](https://www.github.com/googleapis/gax-java/issues/1198)) ([b856351](https://www.github.com/googleapis/gax-java/commit/b85635123f987f9808086f14a58dd8c7418a3bd8)) ##### Dependencies - upgrade grpc to 1.32.2 ([#​1212](https://www.github.com/googleapis/gax-java/issues/1212)) ([03c4c0f](https://www.github.com/googleapis/gax-java/commit/03c4c0f621f439c30752122568d2a9a7703e5e16)) ##### [1.59.1](https://www.github.com/googleapis/gax-java/compare/v1.59.0...v1.59.1) (2020-10-05) ##### Bug Fixes - Fix race condition in BatcherImpl flush ([#​1200](https://www.github.com/googleapis/gax-java/issues/1200)) ([c6308c9](https://www.github.com/googleapis/gax-java/commit/c6308c906171ce05765ccacb716aa7162d95d9a2)) - update owners file with actools-java ([#​1194](https://www.github.com/googleapis/gax-java/issues/1194)) ([9977dd2](https://www.github.com/googleapis/gax-java/commit/9977dd2564ff6919fc6a6b658eb69b5ea8a66520)) ### [`v1.59.1`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1591-httpswwwgithubcomgoogleapisgax-javacomparev1590v1591-2020-10-05) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.59.0...v1.59.1) ### [`v1.59.0`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1590-httpswwwgithubcomgoogleapisgax-javacomparev1583v1590-2020-09-28) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.58.3...v1.59.0) ##### Features - Allow user-agents to be specified by both internal headers and user headers ([#​1190](https://www.github.com/googleapis/gax-java/issues/1190)) ([266329e](https://www.github.com/googleapis/gax-java/commit/266329e89642bfc6be579e600d3f995f4416ae4e)), closes [/github.com/googleapis/java-bigtable/pull/404#pullrequestreview-480972135](https://www.github.com/googleapis//github.com/googleapis/java-bigtable/pull/404/issues/pullrequestreview-480972135) ##### Bug Fixes - truncate RPC timeouts to time remaining in totalTimeout ([#​1191](https://www.github.com/googleapis/gax-java/issues/1191)) ([1d0c940](https://www.github.com/googleapis/gax-java/commit/1d0c94061bab124be81a649ac3fa1ce5d9a2df23)) ##### Dependencies - update guava to 29.0-android ([#​1174](https://www.github.com/googleapis/gax-java/issues/1174)) ([287cada](https://www.github.com/googleapis/gax-java/commit/287cadae528549545da9e7e9d63fd70c1268e3c1)), closes [#​1151](https://www.github.com/googleapis/gax-java/issues/1151) ##### [1.58.3](https://www.github.com/googleapis/gax-java/compare/v1.58.2...v1.58.3) (2020-09-15) ##### Bug Fixes - [gax-java] Add speedy Bazel builds to Travis ([#​1181](https://www.github.com/googleapis/gax-java/issues/1181)) ([2fb85fe](https://www.github.com/googleapis/gax-java/commit/2fb85fed095c6043ee39b63a0f7dff3fd93cbd7b)) - [gax-java] add Vim files to .gitignore ([#​1179](https://www.github.com/googleapis/gax-java/issues/1179)) ([2de22b6](https://www.github.com/googleapis/gax-java/commit/2de22b6645fbfd7ada7d0067e5cdd3c2039ec190)) - [gax-java] Fix broken Bazel build ([#​1180](https://www.github.com/googleapis/gax-java/issues/1180)) ([834c05e](https://www.github.com/googleapis/gax-java/commit/834c05e1d35a17f90bf8cd1b2cdce40bea451c95)) ##### [1.58.2](https://www.github.com/googleapis/gax-java/compare/v1.58.1...v1.58.2) (2020-08-07) ##### Bug Fixes - Settings objects should not try to read quotaProjectId from credentials ([#​1162](https://www.github.com/googleapis/gax-java/issues/1162)) ([1b09bcf](https://www.github.com/googleapis/gax-java/commit/1b09bcff1ddfaed8cfa58b92c787f8fc9b08abef)) ##### [1.58.1](https://www.github.com/googleapis/gax-java/compare/v1.58.0...v1.58.1) (2020-08-06) ##### Bug Fixes - fix dependencies.properties resource file creation during deployment ([#​1163](https://www.github.com/googleapis/gax-java/issues/1163)) ([3e7e1f1](https://www.github.com/googleapis/gax-java/commit/3e7e1f1e64bdeb23a51b5155faea975beec0bc84)) - Watchdog.shutdownNow() does not shutdown executor ([#​1158](https://www.github.com/googleapis/gax-java/issues/1158)) ([6241a21](https://www.github.com/googleapis/gax-java/commit/6241a2118690d07dd28ffb9447423363f3f914e4)) ### [`v1.58.3`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1583-httpswwwgithubcomgoogleapisgax-javacomparev1582v1583-2020-09-15) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.58.2...v1.58.3) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/config-help/issues) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
* feat: populate UserAgent in addition to x-goog-api-client * add a comment
🤖 I have created a release \*beep\* \*boop\* --- ## [1.16.0](https://www.github.com/googleapis/java-bigtable/compare/v1.15.0...v1.16.0) (2020-10-06) ### Features * add keepalive changes in java client library ([googleapis#409](https://www.github.com/googleapis/java-bigtable/issues/409)) ([edbcde1](https://www.github.com/googleapis/java-bigtable/commit/edbcde1a5b22317319803cb57401252aac6d580d)) * include User agent ([googleapis#404](https://www.github.com/googleapis/java-bigtable/issues/404)) ([0cd71b5](https://www.github.com/googleapis/java-bigtable/commit/0cd71b59305cd7a336c223faff68402a8bee4639)) * Ability to extend UserAgent string (via gax upgrade) ### Bug Fixes * **test:** Clean up tests ([googleapis#439](https://www.github.com/googleapis/java-bigtable/issues/439)) ([c5c881b](https://www.github.com/googleapis/java-bigtable/commit/c5c881bb956860a393c2a7f34d0d790a23d270af)) * Add documentation to bulkReadRows that each batch will process t… ([googleapis#410](https://www.github.com/googleapis/java-bigtable/issues/410)) ([71dc8e3](https://www.github.com/googleapis/java-bigtable/commit/71dc8e3419fbb49d48bb7a3fd984d24e24661c81)) * Filters should be serializable ([googleapis#397](https://www.github.com/googleapis/java-bigtable/issues/397)) ([57edfde](https://www.github.com/googleapis/java-bigtable/commit/57edfde5eace28d50ec777e14589c9747616f0a8)) * RowCells are not actually serializeable ([googleapis#407](https://www.github.com/googleapis/java-bigtable/issues/407)) ([39e17cc](https://www.github.com/googleapis/java-bigtable/commit/39e17cc17c438f2d665875f9ff2b2cdf984e37b7)) * Fix race condition in Batcher.close() (via gax upgrade) ### Dependencies * update dependency com.google.cloud:google-cloud-conformance-tests to v0.0.12 ([googleapis#415](https://www.github.com/googleapis/java-bigtable/issues/415)) ([7b3713a](https://www.github.com/googleapis/java-bigtable/commit/7b3713a8935b2f0b1ca57d189e9e0363506b28a1)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([googleapis#428](https://www.github.com/googleapis/java-bigtable/issues/428)) ([373032e](https://www.github.com/googleapis/java-bigtable/commit/373032e93b838cbc0ccab7dc45cd61b3b973542a)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.1 ([googleapis#443](https://www.github.com/googleapis/java-bigtable/issues/443)) ([939fefa](https://www.github.com/googleapis/java-bigtable/commit/939fefa819d09885489d9faeedadc74ee2b0e1b9)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.1 ([googleapis#427](https://www.github.com/googleapis/java-bigtable/issues/427)) ([5175e28](https://www.github.com/googleapis/java-bigtable/commit/5175e28f5ce69f6fb3ed14131c1cfd26dbc47bb9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.api:gax-grpc](https://togithub.com/googleapis/gax-java) | minor | `1.58.2` -> `1.59.1` | | [com.google.api:gax-bom](https://togithub.com/googleapis/gax-java) | minor | `1.58.2` -> `1.59.1` | --- ### Release Notes <details> <summary>googleapis/gax-java</summary> ### [`v1.59.1`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1591-httpswwwgithubcomgoogleapisgax-javacomparev1590v1591-2020-10-05) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.59.0...v1.59.1) ### [`v1.59.0`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1590-httpswwwgithubcomgoogleapisgax-javacomparev1583v1590-2020-09-28) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.58.3...v1.59.0) ##### Features - Allow user-agents to be specified by both internal headers and user headers ([#​1190](https://www.github.com/googleapis/gax-java/issues/1190)) ([266329e](https://www.github.com/googleapis/gax-java/commit/266329e89642bfc6be579e600d3f995f4416ae4e)), closes [/github.com/googleapis/java-bigtable/pull/404#pullrequestreview-480972135](https://www.github.com/googleapis//github.com/googleapis/java-bigtable/pull/404/issues/pullrequestreview-480972135) ##### Bug Fixes - truncate RPC timeouts to time remaining in totalTimeout ([#​1191](https://www.github.com/googleapis/gax-java/issues/1191)) ([1d0c940](https://www.github.com/googleapis/gax-java/commit/1d0c94061bab124be81a649ac3fa1ce5d9a2df23)) ##### Dependencies - update guava to 29.0-android ([#​1174](https://www.github.com/googleapis/gax-java/issues/1174)) ([287cada](https://www.github.com/googleapis/gax-java/commit/287cadae528549545da9e7e9d63fd70c1268e3c1)), closes [#​1151](https://www.github.com/googleapis/gax-java/issues/1151) ##### [1.58.3](https://www.github.com/googleapis/gax-java/compare/v1.58.2...v1.58.3) (2020-09-15) ##### Bug Fixes - [gax-java] Add speedy Bazel builds to Travis ([#​1181](https://www.github.com/googleapis/gax-java/issues/1181)) ([2fb85fe](https://www.github.com/googleapis/gax-java/commit/2fb85fed095c6043ee39b63a0f7dff3fd93cbd7b)) - [gax-java] add Vim files to .gitignore ([#​1179](https://www.github.com/googleapis/gax-java/issues/1179)) ([2de22b6](https://www.github.com/googleapis/gax-java/commit/2de22b6645fbfd7ada7d0067e5cdd3c2039ec190)) - [gax-java] Fix broken Bazel build ([#​1180](https://www.github.com/googleapis/gax-java/issues/1180)) ([834c05e](https://www.github.com/googleapis/gax-java/commit/834c05e1d35a17f90bf8cd1b2cdce40bea451c95)) ##### [1.58.2](https://www.github.com/googleapis/gax-java/compare/v1.58.1...v1.58.2) (2020-08-07) ##### Bug Fixes - Settings objects should not try to read quotaProjectId from credentials ([#​1162](https://www.github.com/googleapis/gax-java/issues/1162)) ([1b09bcf](https://www.github.com/googleapis/gax-java/commit/1b09bcff1ddfaed8cfa58b92c787f8fc9b08abef)) ##### [1.58.1](https://www.github.com/googleapis/gax-java/compare/v1.58.0...v1.58.1) (2020-08-06) ##### Bug Fixes - fix dependencies.properties resource file creation during deployment ([#​1163](https://www.github.com/googleapis/gax-java/issues/1163)) ([3e7e1f1](https://www.github.com/googleapis/gax-java/commit/3e7e1f1e64bdeb23a51b5155faea975beec0bc84)) - Watchdog.shutdownNow() does not shutdown executor ([#​1158](https://www.github.com/googleapis/gax-java/issues/1158)) ([6241a21](https://www.github.com/googleapis/gax-java/commit/6241a2118690d07dd28ffb9447423363f3f914e4)) ### [`v1.58.3`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1583-httpswwwgithubcomgoogleapisgax-javacomparev1582v1583-2020-09-15) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.58.2...v1.58.3) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | patch | `1.32.1` -> `1.32.2` | | [com.google.auth:google-auth-library-bom](https://togithub.com/googleapis/google-auth-library-java) | minor | `0.21.1` -> `0.22.0` | | [com.google.api:gax-bom](https://togithub.com/googleapis/gax-java) | minor | `1.58.2` -> `1.60.0` | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.32.2`](https://togithub.com/grpc/grpc-java/releases/v1.32.2) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.32.1...v1.32.2) ##### Bug Fixes - netty: TCP close during TLS handshake should be UNAVAILABLE, not UNKNOWN - netty: BDP ping accounting should occur after flow control. This resolves an incompatibility issue introduced in v1.30.0 and could be worked around via `GRPC_EXPERIMENTAL_AUTOFLOWCONTROL=false` introduced later. The symptom was a GOAWAY with “too_many_pings” without an aggressive keepalive configured. The environment variable is still available, but will be removed in the future - alts: Reverted workaround for Conscrypt cipher performance. Conscrypt 2.5.0 has significantly improved performance and the workaround now decreases performance. Note that grpc-alts itself still depends on Conscrypt 2.2.1 to remain stable for this bug fix release, but users are encouraged to use newer a version of Conscrypt. The gains from Conscrypt 2.5.0 are significantly greater than what the workaround provided </details> <details> <summary>googleapis/google-auth-library-java</summary> ### [`v0.22.0`](https://togithub.com/googleapis/google-auth-library-java/blob/master/CHANGELOG.md#​0220-httpswwwgithubcomgoogleapisgoogle-auth-library-javacomparev0211v0220-2020-10-13) [Compare Source](https://togithub.com/googleapis/google-auth-library-java/compare/v0.21.1...v0.22.0) ##### Features - add logging at FINE level for each step of ADC ([#​435](https://www.github.com/googleapis/google-auth-library-java/issues/435)) ([7d145b2](https://www.github.com/googleapis/google-auth-library-java/commit/7d145b2371033093ea13fd05520c90970a5ef363)) ##### Documentation - remove bad javadoc tags ([#​478](https://www.github.com/googleapis/google-auth-library-java/issues/478)) ([a329c41](https://www.github.com/googleapis/google-auth-library-java/commit/a329c4171735c3d4ee574978e6c3742b96c01f74)) ##### Dependencies - update dependency com.google.http-client:google-http-client-bom to v1.37.0 ([#​486](https://www.github.com/googleapis/google-auth-library-java/issues/486)) ([3027fbf](https://www.github.com/googleapis/google-auth-library-java/commit/3027fbfaf017f5aa5a22cc51cd38a522597729c0)) ##### [0.21.1](https://www.github.com/googleapis/google-auth-library-java/compare/v0.21.0...v0.21.1) (2020-07-07) ##### Dependencies - update google-http-client to 1.36.0 ([#​447](https://www.github.com/googleapis/google-auth-library-java/issues/447)) ([b913d19](https://www.github.com/googleapis/google-auth-library-java/commit/b913d194259e4f93bb401a844480f56b48dad3bd)), closes [#​446](https://www.github.com/googleapis/google-auth-library-java/issues/446) </details> <details> <summary>googleapis/gax-java</summary> ### [`v1.60.0`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1600-httpswwwgithubcomgoogleapisgax-javacomparev1591v1600-2020-10-19) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.59.1...v1.60.0) ##### Features - REST Gapic (REGAPIC) Support ([#​1177](https://www.github.com/googleapis/gax-java/issues/1177)) ([12b18ee](https://www.github.com/googleapis/gax-java/commit/12b18ee255d3fabe13bb3969df40753b29f830d5)) ##### Bug Fixes - prevent npe caused by missing parentheses ([#​1198](https://www.github.com/googleapis/gax-java/issues/1198)) ([b856351](https://www.github.com/googleapis/gax-java/commit/b85635123f987f9808086f14a58dd8c7418a3bd8)) ##### Dependencies - upgrade grpc to 1.32.2 ([#​1212](https://www.github.com/googleapis/gax-java/issues/1212)) ([03c4c0f](https://www.github.com/googleapis/gax-java/commit/03c4c0f621f439c30752122568d2a9a7703e5e16)) ##### [1.59.1](https://www.github.com/googleapis/gax-java/compare/v1.59.0...v1.59.1) (2020-10-05) ##### Bug Fixes - Fix race condition in BatcherImpl flush ([#​1200](https://www.github.com/googleapis/gax-java/issues/1200)) ([c6308c9](https://www.github.com/googleapis/gax-java/commit/c6308c906171ce05765ccacb716aa7162d95d9a2)) - update owners file with actools-java ([#​1194](https://www.github.com/googleapis/gax-java/issues/1194)) ([9977dd2](https://www.github.com/googleapis/gax-java/commit/9977dd2564ff6919fc6a6b658eb69b5ea8a66520)) ### [`v1.59.1`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1591-httpswwwgithubcomgoogleapisgax-javacomparev1590v1591-2020-10-05) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.59.0...v1.59.1) ### [`v1.59.0`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1590-httpswwwgithubcomgoogleapisgax-javacomparev1583v1590-2020-09-28) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.58.3...v1.59.0) ##### Features - Allow user-agents to be specified by both internal headers and user headers ([#​1190](https://www.github.com/googleapis/gax-java/issues/1190)) ([266329e](https://www.github.com/googleapis/gax-java/commit/266329e89642bfc6be579e600d3f995f4416ae4e)), closes [/github.com/googleapis/java-bigtable/pull/404#pullrequestreview-480972135](https://www.github.com/googleapis//github.com/googleapis/java-bigtable/pull/404/issues/pullrequestreview-480972135) ##### Bug Fixes - truncate RPC timeouts to time remaining in totalTimeout ([#​1191](https://www.github.com/googleapis/gax-java/issues/1191)) ([1d0c940](https://www.github.com/googleapis/gax-java/commit/1d0c94061bab124be81a649ac3fa1ce5d9a2df23)) ##### Dependencies - update guava to 29.0-android ([#​1174](https://www.github.com/googleapis/gax-java/issues/1174)) ([287cada](https://www.github.com/googleapis/gax-java/commit/287cadae528549545da9e7e9d63fd70c1268e3c1)), closes [#​1151](https://www.github.com/googleapis/gax-java/issues/1151) ##### [1.58.3](https://www.github.com/googleapis/gax-java/compare/v1.58.2...v1.58.3) (2020-09-15) ##### Bug Fixes - [gax-java] Add speedy Bazel builds to Travis ([#​1181](https://www.github.com/googleapis/gax-java/issues/1181)) ([2fb85fe](https://www.github.com/googleapis/gax-java/commit/2fb85fed095c6043ee39b63a0f7dff3fd93cbd7b)) - [gax-java] add Vim files to .gitignore ([#​1179](https://www.github.com/googleapis/gax-java/issues/1179)) ([2de22b6](https://www.github.com/googleapis/gax-java/commit/2de22b6645fbfd7ada7d0067e5cdd3c2039ec190)) - [gax-java] Fix broken Bazel build ([#​1180](https://www.github.com/googleapis/gax-java/issues/1180)) ([834c05e](https://www.github.com/googleapis/gax-java/commit/834c05e1d35a17f90bf8cd1b2cdce40bea451c95)) ##### [1.58.2](https://www.github.com/googleapis/gax-java/compare/v1.58.1...v1.58.2) (2020-08-07) ##### Bug Fixes - Settings objects should not try to read quotaProjectId from credentials ([#​1162](https://www.github.com/googleapis/gax-java/issues/1162)) ([1b09bcf](https://www.github.com/googleapis/gax-java/commit/1b09bcff1ddfaed8cfa58b92c787f8fc9b08abef)) ##### [1.58.1](https://www.github.com/googleapis/gax-java/compare/v1.58.0...v1.58.1) (2020-08-06) ##### Bug Fixes - fix dependencies.properties resource file creation during deployment ([#​1163](https://www.github.com/googleapis/gax-java/issues/1163)) ([3e7e1f1](https://www.github.com/googleapis/gax-java/commit/3e7e1f1e64bdeb23a51b5155faea975beec0bc84)) - Watchdog.shutdownNow() does not shutdown executor ([#​1158](https://www.github.com/googleapis/gax-java/issues/1158)) ([6241a21](https://www.github.com/googleapis/gax-java/commit/6241a2118690d07dd28ffb9447423363f3f914e4)) ### [`v1.58.3`](https://togithub.com/googleapis/gax-java/blob/master/CHANGELOG.md#​1583-httpswwwgithubcomgoogleapisgax-javacomparev1582v1583-2020-09-15) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v1.58.2...v1.58.3) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/config-help/issues) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
Configure the UserAgent in addition to x-goog-api-client. This will be needed for DirectPath
This depends on #398 for the test changes