Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade shared config to 1.5.3, exclude google-http-client and google-http-client-gson from gax in google-cloud-bigtable-stats #1336

Merged
merged 5 commits into from
Aug 2, 2022
Merged

deps: upgrade shared config to 1.5.3, exclude google-http-client and google-http-client-gson from gax in google-cloud-bigtable-stats #1336

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34c318c
deps: upgrade shared config to 1.5.3, remove google-http-client and g…
blakeli0 Aug 2, 2022
a68d5e9
exclude google-http-client and google-http-client-gson from google-cl…
blakeli0 Aug 2, 2022
1cbfa75
exclude google-http-client and google-http-client-gson from google-cl…
blakeli0 Aug 2, 2022
014bf39
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 2, 2022
2703c0d
Add comments to explain excluded dependencies.
blakeli0 Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ implementation 'com.google.cloud:google-cloud-bigtable'
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-bigtable:2.10.0'
implementation 'com.google.cloud:google-cloud-bigtable:2.10.1'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "2.10.0"
libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "2.10.1"
```

## Authentication
Expand Down
10 changes: 10 additions & 0 deletions google-cloud-bigtable-stats/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax</artifactId>
<exclusions>
<exclusion>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client</artifactId>
Copy link
Member

@suztomo suztomo Aug 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that GAX can work without google-http-client, in library users' environment?

If yes, can you add source-code comment explains why this exclusion does not give any harm to library users' environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only excluding google-http-client from google-cloud-bigtable-stats, not from google-cloud-bigtable. I checked the usage of gax in google-cloud-bigtable-stats, which appears to be only referencing a few annotations, plus the integration tests should catch it if they are required.
We can make all checks pass by either excluding these here or add them to the exclude list in the dependency list check here.
Is there any best practices that prefer not to exclude dependencies? If not, I feel this solution is better since we don't need them, so instead of exclude them in the check, I'd rather exclude them in the pom directly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Excluding the unnecessary dependency is better in that has difference in users class path. It's good that these dependencies are not used.

</exclusion>
<exclusion>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client-gson</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
Expand Down
18 changes: 10 additions & 8 deletions google-cloud-bigtable/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,6 @@
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client</artifactId>
</dependency>
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client-gson</artifactId>
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
Expand Down Expand Up @@ -270,6 +262,16 @@
<artifactId>opencensus-impl</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client-gson</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-shared-config</artifactId>
<version>1.5.1</version>
<version>1.5.3</version>
</parent>

<developers>
Expand Down